1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Set#merge: raise if called during iteration

Browse Source 
[Bug #21332]
This commit is contained in:
Jean Boussier 2025-05-13 21:39:48 +02:00
parent 1d4822a175
commit 1ee4b43a56
Notes: git 2025-05-13 20:27:55 +00:00 
Merged: https://github.com/ruby/ruby/pull/13322
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
set.c
View File

@ -1139,6 +1139,11 @@ set_i_merge(int argc, VALUE *argv, VALUE set)
if (rb_keyword_given_p()) { if (rb_keyword_given_p()) {
rb_raise(rb_eArgError, "no keywords accepted"); rb_raise(rb_eArgError, "no keywords accepted");
} }
if (set_iterating_p(set)) {
rb_raise(rb_eRuntimeError, "cannot add to set during iteration");
}
rb_check_frozen(set); rb_check_frozen(set);
int i; int i;

7
spec/ruby/core/set/merge_spec.rb
View File

@ -16,6 +16,13 @@ describe "Set#merge" do
-> { Set[1, 2].merge(Object.new) }.should raise_error(ArgumentError) -> { Set[1, 2].merge(Object.new) }.should raise_error(ArgumentError)
end end
it "raises RuntimeError when called during iteration" do
set = Set[:a, :b]
set.each do |_m|
-> { set.merge([1, 2]) }.should raise_error(RuntimeError, /iteration/)
end
end
ruby_version_is ""..."3.3" do ruby_version_is ""..."3.3" do
it "accepts only a single argument" do it "accepts only a single argument" do
-> { Set[].merge([], []) }.should raise_error(ArgumentError, "wrong number of arguments (given 2, expected 1)") -> { Set[].merge([], []) }.should raise_error(ArgumentError, "wrong number of arguments (given 2, expected 1)")