From 1c871c08d9dc9893968067de339abd0e05836d74 Mon Sep 17 00:00:00 2001 From: John Hawthorn Date: Wed, 11 Oct 2023 11:30:10 -0700 Subject: [PATCH] Switch mid dump to dump_append_string_value I don't think it's possible to create a CI with a mid which would need escaping to be in a JSON string, but I think we might as well not rely on that assumption. --- ext/objspace/objspace_dump.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ext/objspace/objspace_dump.c b/ext/objspace/objspace_dump.c index 50dead5773..bcee5312fc 100644 --- a/ext/objspace/objspace_dump.c +++ b/ext/objspace/objspace_dump.c @@ -436,9 +436,8 @@ dump_object(VALUE obj, struct dump_config *dc) case imemo_callinfo: mid = vm_ci_mid((const struct rb_callinfo *)obj); if (mid != 0) { - dump_append(dc, ", \"mid\":\""); - dump_append(dc, rb_id2name(mid)); - dump_append(dc, "\""); + dump_append(dc, ", \"mid\":"); + dump_append_string_value(dc, rb_id2str(mid)); } break;