1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky test_latest_gc_info_need_major_by

Browse Source 
It's possible for a GC to run between the calls of GC.latest_gc_info,
which would cause the test to fail. We can disable GC so that GC only
triggers manually.
This commit is contained in:
Peter Zhu 2024-08-30 15:17:06 -04:00
parent c1fecc5eab
commit 1b82d63462
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/ruby/test_gc.rb
View File

@ -374,15 +374,17 @@ class TestGc < Test::Unit::TestCase
objects.append(100.times.map { '*' })
end
# We need to ensure that no GC gets ran before the call to GC.start since
# it would trigger a major GC. Assertions could allocate objects and
# trigger a GC so we don't run assertions until we perform the major GC.
need_major_by = GC.latest_gc_info(:need_major_by)
GC.start(full_mark: false) # should be upgraded to major
major_by = GC.latest_gc_info(:major_by)
EnvUtil.without_gc do
# We need to ensure that no GC gets ran before the call to GC.start since
# it would trigger a major GC. Assertions could allocate objects and
# trigger a GC so we don't run assertions until we perform the major GC.
need_major_by = GC.latest_gc_info(:need_major_by)
GC.start(full_mark: false) # should be upgraded to major
major_by = GC.latest_gc_info(:major_by)
assert_not_nil(need_major_by)
assert_not_nil(major_by)
assert_not_nil(need_major_by)
assert_not_nil(major_by)
end
end
def test_latest_gc_info_weak_references_count