1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix flaky test_stat_heap_all

Browse Source 
We only collect GC.stat_heap(nil, stat_heap_all)
once, outside of the loop, but assert_equal could
allocate objects which can cause a GC to run and
cause stat_heap_all to be out-of-sync.
This commit is contained in:
Peter Zhu 2024-06-21 11:41:32 -04:00
parent 685a4e5be7
commit 1afcaa3e4b
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
test/ruby/test_gc.rb
View File

@ -186,13 +186,12 @@ class TestGc < Test::Unit::TestCase
omit "flaky with RJIT, which allocates objects itself" if defined?(RubyVM::RJIT) && RubyVM::RJIT.enabled? omit "flaky with RJIT, which allocates objects itself" if defined?(RubyVM::RJIT) && RubyVM::RJIT.enabled?
stat_heap_all = {} stat_heap_all = {}
stat_heap = {} stat_heap = {}
# Initialize to prevent GC in future calls
2.times do GC.stat_heap(0, stat_heap)
GC.stat_heap(0, stat_heap) GC.stat_heap(nil, stat_heap_all)
GC.stat_heap(nil, stat_heap_all)
end
GC::INTERNAL_CONSTANTS[:SIZE_POOL_COUNT].times do |i| GC::INTERNAL_CONSTANTS[:SIZE_POOL_COUNT].times do |i|
GC.stat_heap(nil, stat_heap_all)
GC.stat_heap(i, stat_heap) GC.stat_heap(i, stat_heap)
# Remove keys that can vary between invocations # Remove keys that can vary between invocations