1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug in array pack with shared strings

Browse Source 
If string literals are long and they become shared, we need to make them
independent before we can write to them. [Bug #19116]
This commit is contained in:
Jemma Issroff 2022-11-09 17:04:35 -05:00 committed by Peter Zhu
parent 68bd1d6855
commit 199b59f065
Notes: git 2022-11-10 14:27:06 +00:00 
Merged: https://github.com/ruby/ruby/pull/6704
2 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pack.c
View File

@ -217,6 +217,7 @@ pack_pack(rb_execution_context_t *ec, VALUE ary, VALUE fmt, VALUE buffer)
else { else {
if (!RB_TYPE_P(buffer, T_STRING)) if (!RB_TYPE_P(buffer, T_STRING))
rb_raise(rb_eTypeError, "buffer must be String, not %s", rb_obj_classname(buffer)); rb_raise(rb_eTypeError, "buffer must be String, not %s", rb_obj_classname(buffer));
rb_str_modify(buffer);
res = buffer; res = buffer;
} }

6
test/ruby/test_array.rb
View File

@ -1294,6 +1294,12 @@ class TestArray < Test::Unit::TestCase
=end =end
end end
def test_pack_with_buffer
n = [ 65, 66, 67 ]
str = "a" * 100
assert_equal("aaaABC", n.pack("@3ccc", buffer: str.dup), "[Bug #19116]")
end
def test_pop def test_pop
a = @cls[ 'cat', 'dog' ] a = @cls[ 'cat', 'dog' ]
assert_equal('dog', a.pop) assert_equal('dog', a.pop)