1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use rb_inspect instead of +PRIsVALUE for Object.inspect

Browse Source 
In order to preserve the values when TrueClass, FalseClass or NilClass
are stored in ivars
This commit is contained in:
Matt Valentine-House 2022-12-07 16:01:37 +00:00 committed by Nobuyoshi Nakada
parent 7c438328d5
commit 181d4bee5e
Notes: git 2022-12-09 13:11:19 +00:00 
Merged: https://github.com/ruby/ruby/pull/6872
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
object.c
View File

@ -677,8 +677,8 @@ inspect_i(st_data_t k, st_data_t v, st_data_t a)
else { else {
rb_str_cat2(str, ", "); rb_str_cat2(str, ", ");
} }
rb_str_catf(str, "%"PRIsVALUE"=%+"PRIsVALUE, rb_str_catf(str, "%"PRIsVALUE"=", rb_id2str(id));
rb_id2str(id), value); rb_str_buf_append(str, rb_inspect(value));
return ST_CONTINUE; return ST_CONTINUE;
} }

9
test/ruby/test_object.rb
View File

@ -853,6 +853,15 @@ class TestObject < Test::Unit::TestCase
x.instance_variable_set(:@bar, 42) x.instance_variable_set(:@bar, 42)
assert_match(/\A#<Object:0x\h+ (?:@foo="value", @bar=42|@bar=42, @foo="value")>\z/, x.inspect) assert_match(/\A#<Object:0x\h+ (?:@foo="value", @bar=42|@bar=42, @foo="value")>\z/, x.inspect)
# Bug: [ruby-core:19167]
x = Object.new
x.instance_variable_set(:@foo, NilClass)
assert_match(/\A#<Object:0x\h+ @foo=NilClass>\z/, x.inspect)
x.instance_variable_set(:@foo, TrueClass)
assert_match(/\A#<Object:0x\h+ @foo=TrueClass>\z/, x.inspect)
x.instance_variable_set(:@foo, FalseClass)
assert_match(/\A#<Object:0x\h+ @foo=FalseClass>\z/, x.inspect)
# #inspect does not call #to_s anymore # #inspect does not call #to_s anymore
feature6130 = '[ruby-core:43238]' feature6130 = '[ruby-core:43238]'
x = Object.new x = Object.new