From 1731dd05a7f9fcdef1ea1c25f7a3e072679c3d3a Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Mon, 6 Nov 2023 12:37:16 -0800 Subject: [PATCH] Eliminate array allocation for f(*a, **lvar) and f(*a, **@iv) The compiler already eliminates the array allocation for f(*a, &lvar) and f(*a, &@iv), and eliminating the array allocation for keyword splat is as safe as eliminating it for block passes. --- compile.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/compile.c b/compile.c index 1f3b0920de..4ba332ff1f 100644 --- a/compile.c +++ b/compile.c @@ -3876,6 +3876,21 @@ iseq_peephole_optimize(rb_iseq_t *iseq, LINK_ELEMENT *list, const int do_tailcal if ((flag & VM_CALL_ARGS_BLOCKARG) && !(flag & VM_CALL_KW_SPLAT)) { OPERAND_AT(iobj, 0) = Qfalse; } + + /* + * Eliminate array allocation for f(*a, **lvar) and f(*a, **@iv) + * + * splatarray true + * getlocal / getinstancevariable + * send ARGS_SPLAT|KW_SPLAT and not ARGS_BLOCKARG + * => + * splatarray false + * getlocal / getinstancevariable + * send + */ + else if (!(flag & VM_CALL_ARGS_BLOCKARG) && (flag & VM_CALL_KW_SPLAT)) { + OPERAND_AT(iobj, 0) = Qfalse; + } } } }