1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove excess allocation for kwsplat to kw call

Browse Source 
Previously, calls like the following duplicated the kwsplat hash
unnecessarily:

```ruby
def foo(a:) = a
hash = {a: 10}
foo(**hash)
```

This is due to the fix in ca204a20231. Since it targets when the callee
has no keyword parameters, skip duplicating when the method takes
keywords.
This commit is contained in:
Alan Wu 2024-03-20 16:21:04 -04:00
parent 806edd2956
commit 15dc3aaa31
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
vm_args.c
View File

@ -725,8 +725,9 @@ setup_parameters_complex(rb_execution_context_t * const ec, const rb_iseq_t * co
kw_flag &= ~(VM_CALL_KW_SPLAT | VM_CALL_KW_SPLAT_MUT); kw_flag &= ~(VM_CALL_KW_SPLAT | VM_CALL_KW_SPLAT_MUT);
} }
else { else {
if (!(kw_flag & VM_CALL_KW_SPLAT_MUT)) { if (!(kw_flag & VM_CALL_KW_SPLAT_MUT) && !ISEQ_BODY(iseq)->param.flags.has_kw) {
converted_keyword_hash = rb_hash_dup(converted_keyword_hash); converted_keyword_hash = rb_hash_dup(converted_keyword_hash);
kw_flag |= VM_CALL_KW_SPLAT_MUT;
} }
if (last_arg != converted_keyword_hash) { if (last_arg != converted_keyword_hash) {