1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make optional benchmark test in OpenSSL::OSSL#test_memcmp_timing

Browse Source
This commit is contained in:
Hiroshi SHIBATA 2024-08-29 10:53:53 +09:00
parent 4e5b3e58e2
commit 1515353353
Notes: git 2024-08-29 08:38:03 +00:00 
Merged: https://github.com/ruby/ruby/pull/11490
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
test/openssl/test_ossl.rb
View File

@ -1,8 +1,6 @@
# frozen_string_literal: true # frozen_string_literal: true
require_relative "utils" require_relative "utils"
require 'benchmark'
if defined?(OpenSSL) if defined?(OpenSSL)
class OpenSSL::OSSL < OpenSSL::SSLTestCase class OpenSSL::OSSL < OpenSSL::SSLTestCase
@ -44,6 +42,12 @@ class OpenSSL::OSSL < OpenSSL::SSLTestCase
end end
def test_memcmp_timing def test_memcmp_timing
begin
require "benchmark"
rescue LoadError
pend "Benchmark is not available in this environment. Please install it with `gem install benchmark`."
end
# Ensure using fixed_length_secure_compare takes almost exactly the same amount of time to compare two different strings. # Ensure using fixed_length_secure_compare takes almost exactly the same amount of time to compare two different strings.
# Regular string comparison will short-circuit on the first non-matching character, failing this test. # Regular string comparison will short-circuit on the first non-matching character, failing this test.
# NOTE: this test may be susceptible to noise if the system running the tests is otherwise under load. # NOTE: this test may be susceptible to noise if the system running the tests is otherwise under load.