From 10d6ee65542a756072afb7182216efff80aa97d7 Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Tue, 8 Apr 2025 15:20:45 +0900 Subject: [PATCH] Skip some assertions of TestFileExhaustive#test_dirname with Windows platform. These assertions didn't handle drive letter of Windows ``` 1) Failure: TestFileExhaustive#test_dirname [V:/github.com/ruby/ruby/test/ruby/test_file_exhaustive.rb:1282]: <"V:/"> expected but was <"C:/">. ``` --- test/ruby/test_file_exhaustive.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/ruby/test_file_exhaustive.rb b/test/ruby/test_file_exhaustive.rb index f3068cb189..aed0a5d4dd 100644 --- a/test/ruby/test_file_exhaustive.rb +++ b/test/ruby/test_file_exhaustive.rb @@ -1278,7 +1278,7 @@ class TestFileExhaustive < Test::Unit::TestCase assert_equal(regular_file, File.dirname(regular_file, 0)) assert_equal(@dir, File.dirname(regular_file, 1)) assert_equal(File.dirname(@dir), File.dirname(regular_file, 2)) - return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # rootdir and tmpdir are in different drives + return if /mswin/ =~ RUBY_PLATFORM # mswin allows rootdir and tmpdir are in different drives assert_equal(rootdir, File.dirname(regular_file, regular_file.count('/'))) assert_raise(ArgumentError) {File.dirname(regular_file, -1)} end