1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Launchable: Fix launchable record session command failures (#12810)

Browse Source 
Currently, the `launchable record session` command is failing some workflows such as YJIT on macOS. This occurs because of word splitting, as explained in https://www.shellcheck.net/wiki/SC2086. This PR addresses the issue.

```
+ launchable record session --build refs_pull_12785_merge_5ac818aaf7402e232de6b3e1b078765da3dc6279 --observation --flavor os=macos-14 --flavor test_task=check --flavor test_opts=--enable-yjit --flavor workflow=YJIT macOS Arm64 --test-suite yjit-test-all
Usage: launchable record session [OPTIONS]
Try 'launchable record session --help' for help.

Error: Got unexpected extra arguments (macOS Arm64)
Error: Process completed with exit code 2.
```

https://github.com/ruby/ruby/actions/runs/13535324545/job/37825826044#step:10:354
This commit is contained in:
Naoto Ono 2025-02-26 12:50:54 +09:00 committed by GitHub
parent 14192921f5
commit 0c9f149b4d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
Notes: git 2025-02-26 03:51:12 +00:00 
Merged-By: ono-max <onoto1998@gmail.com>
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
.github/actions/launchable/setup/action.yml vendored
View File

@ -159,10 +159,10 @@ runs:
launchable record session \
--build "${build_name}" \
--observation \
--flavor os=${{ inputs.os }} \
--flavor test_task=${{ inputs.test-task }} \
--flavor test_opts=${test_opts} \
--flavor workflow=${{ github.workflow }} \
--flavor os="${{ inputs.os }}" \
--flavor test_task="${{ inputs.test-task }}" \
--flavor test_opts="${test_opts}" \
--flavor workflow="${{ github.workflow }}" \
--test-suite ${test_all_test_suite} \
> "${test_all_session_file}"
launchable subset \
@ -177,10 +177,10 @@ runs:
launchable record session \
--build "${build_name}" \
--observation \
--flavor os=${{ inputs.os }} \
--flavor test_task=${{ inputs.test-task }} \
--flavor test_opts=${test_opts} \
--flavor workflow=${{ github.workflow }} \
--flavor os="${{ inputs.os }}" \
--flavor test_task="${{ inputs.test-task }}" \
--flavor test_opts="${test_opts}" \
--flavor workflow="${{ github.workflow }}" \
--test-suite ${btest_test_suite} \
> "${btest_session_file}"
launchable subset \
@ -195,10 +195,10 @@ runs:
launchable record session \
--build "${build_name}" \
--observation \
--flavor os=${{ inputs.os }} \
--flavor test_task=${{ inputs.test-task }} \
--flavor test_opts=${test_opts} \
--flavor workflow=${{ github.workflow }} \
--flavor os="${{ inputs.os }}" \
--flavor test_task="${{ inputs.test-task }}" \
--flavor test_opts="${test_opts}" \
--flavor workflow="${{ github.workflow }}" \
--test-suite ${test_spec_test_suite} \
> "${test_spec_session_file}"
launchable subset \