1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

rb_class_modify_check: do not goto into a branch

Browse Source 
I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
This commit is contained in:
卜部昌平 2020-06-15 11:58:30 +09:00
parent a2677815f5
commit 0b1b734515
Notes: git 2020-06-29 11:07:07 +09:00 
Merged: https://github.com/ruby/ruby/pull/3247
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
eval.c
View File

@ -456,7 +456,6 @@ void
rb_class_modify_check(VALUE klass) rb_class_modify_check(VALUE klass)
{ {
if (SPECIAL_CONST_P(klass)) { if (SPECIAL_CONST_P(klass)) {
noclass:
Check_Type(klass, T_CLASS); Check_Type(klass, T_CLASS);
} }
if (OBJ_FROZEN(klass)) { if (OBJ_FROZEN(klass)) {
@ -489,7 +488,7 @@ rb_class_modify_check(VALUE klass)
desc = "class"; desc = "class";
break; break;
default: default:
goto noclass; Check_Type(klass, T_CLASS);
} }
} }
rb_frozen_error_raise(klass, "can't modify frozen %s: %"PRIsVALUE, desc, klass); rb_frozen_error_raise(klass, "can't modify frozen %s: %"PRIsVALUE, desc, klass);