1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

YJIT: Pass options to ruby/spec with -T (#10599)

Browse Source 
We recently found out that `make test-spec` wasn't testing with
`--yjit-call-threshold=1` like the other test suites, and that we need
to use `-T` to pass options to it.
This commit is contained in:
Alan Wu 2024-04-29 16:54:39 -04:00 committed by GitHub
parent 470eceff8f
commit 0aefd2f784
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
.github/workflows/yjit-macos.yml vendored
View File

@ -60,11 +60,13 @@ jobs:
- test_task: 'check' - test_task: 'check'
configure: '--enable-yjit=dev' configure: '--enable-yjit=dev'
yjit_opts: '--yjit-call-threshold=1 --yjit-verify-ctx --yjit-code-gc' yjit_opts: '--yjit-call-threshold=1 --yjit-verify-ctx --yjit-code-gc'
specopts: '-T --yjit-call-threshold=1 -T --yjit-verify-ctx -T --yjit-code-gc'
fail-fast: false fail-fast: false
env: env:
GITPULLOPTIONS: --no-tags origin ${{ github.ref }} GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
RUN_OPTS: ${{ matrix.yjit_opts }} RUN_OPTS: ${{ matrix.yjit_opts }}
SPECOPTS: ${{ matrix.specopts }}
runs-on: ${{ github.repository == 'ruby/ruby' && 'macos-arm-oss' || 'macos-14' }} runs-on: ${{ github.repository == 'ruby/ruby' && 'macos-arm-oss' || 'macos-14' }}
@ -128,6 +130,7 @@ jobs:
run: >- run: >-
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
RUN_OPTS="$RUN_OPTS" RUN_OPTS="$RUN_OPTS"
SPECOPTS="$SPECOPTS"
timeout-minutes: 60 timeout-minutes: 60
env: env:
RUBY_TESTOPTS: '-q --tty=no' RUBY_TESTOPTS: '-q --tty=no'

4
.github/workflows/yjit-ubuntu.yml vendored
View File

@ -95,6 +95,7 @@ jobs:
- test_task: 'check' - test_task: 'check'
configure: '--enable-yjit=dev' configure: '--enable-yjit=dev'
yjit_opts: '--yjit-call-threshold=1 --yjit-verify-ctx --yjit-code-gc' yjit_opts: '--yjit-call-threshold=1 --yjit-verify-ctx --yjit-code-gc'
specopts: '-T --yjit-call-threshold=1 -T --yjit-verify-ctx -T --yjit-code-gc'
- test_task: 'test-bundled-gems' - test_task: 'test-bundled-gems'
configure: '--enable-yjit=dev' configure: '--enable-yjit=dev'
@ -108,6 +109,7 @@ jobs:
GITPULLOPTIONS: --no-tags origin ${{ github.ref }} GITPULLOPTIONS: --no-tags origin ${{ github.ref }}
RUN_OPTS: ${{ matrix.yjit_opts }} RUN_OPTS: ${{ matrix.yjit_opts }}
YJIT_BENCH_OPTS: ${{ matrix.yjit_bench_opts }} YJIT_BENCH_OPTS: ${{ matrix.yjit_bench_opts }}
SPECOPTS: ${{ matrix.specopts }}
RUBY_DEBUG: ci RUBY_DEBUG: ci
BUNDLE_JOBS: 8 # for yjit-bench BUNDLE_JOBS: 8 # for yjit-bench
RUST_BACKTRACE: 1 RUST_BACKTRACE: 1
@ -180,7 +182,7 @@ jobs:
- name: make ${{ matrix.test_task }} - name: make ${{ matrix.test_task }}
run: >- run: >-
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"} make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug RUN_OPTS="$RUN_OPTS" MSPECOPT=--debug SPECOPTS="$SPECOPTS"
YJIT_BENCH_OPTS="$YJIT_BENCH_OPTS" YJIT_BINDGEN_DIFF_OPTS="$YJIT_BINDGEN_DIFF_OPTS" YJIT_BENCH_OPTS="$YJIT_BENCH_OPTS" YJIT_BINDGEN_DIFF_OPTS="$YJIT_BINDGEN_DIFF_OPTS"
timeout-minutes: 90 timeout-minutes: 90
env: env: