From 0a4129cb7a4e46b810046ccf04e73ec5db6166a8 Mon Sep 17 00:00:00 2001 From: zzak Date: Wed, 9 Sep 2015 02:12:52 +0000 Subject: [PATCH] =?UTF-8?q?*=20lib/delegate.rb:=20Remove=20backtrace=20cle?= =?UTF-8?q?aning=20for=20delegated=20methods=20=20=20This=20patch=20was=20?= =?UTF-8?q?provided=20by=20Rafael=20Fran=C3=A7a=20and=20greatly=20improves?= =?UTF-8?q?=20=20=20performance=20when=20an=20exception=20is=20raised.=20[?= =?UTF-8?q?Bug=20#11461]?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before: Calculating ------------------------------------- default 86.209k i/100ms default raising 2.209k i/100ms ------------------------------------------------- default 1.953M (±11.0%) i/s - 9.655M default raising 21.826k (±13.5%) i/s - 108.241k After: Calculating ------------------------------------- default 72.211k i/100ms default raising 34.288k i/100ms ------------------------------------------------- default 2.013M (±18.7%) i/s - 9.460M default raising 623.950k (± 9.7%) i/s - 3.120M Benchmark: require 'delegate' require 'benchmark/ips' class Foo def name 'foo' end def bla raise end end class Bar < DelegateClass(Foo) end bar = Bar.new(Foo.new) Benchmark.ips do |b| b.report('default') { bar.name } b.report('default raising') { bar.bla rescue nil } end git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@51806 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 6 ++++++ lib/delegate.rb | 23 ++++++++--------------- 2 files changed, 14 insertions(+), 15 deletions(-) diff --git a/ChangeLog b/ChangeLog index ebaf43fb0a..c96c8780bf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Wed Sep 9 11:08:59 2015 Zachary Scott + + * lib/delegate.rb: Remove backtrace cleaning for delegated methods + This patch was provided by Rafael França and greatly improves + performance when an exception is raised. [Bug #11461] + Wed Sep 9 10:05:41 2015 SHIBATA Hiroshi * test/rubygems/test_config.rb: fix broken tests for Windows platform. diff --git a/lib/delegate.rb b/lib/delegate.rb index a326fa1fda..7a6a2a7a7b 100644 --- a/lib/delegate.rb +++ b/lib/delegate.rb @@ -77,16 +77,13 @@ class Delegator < BasicObject def method_missing(m, *args, &block) r = true target = self.__getobj__ {r = false} - begin - if r && target.respond_to?(m) - target.__send__(m, *args, &block) - elsif ::Kernel.respond_to?(m, true) - ::Kernel.instance_method(m).bind(self).(*args, &block) - else - super(m, *args, &block) - end - ensure - $@.delete_if {|t| %r"\A#{Regexp.quote(__FILE__)}:(?:#{[__LINE__-7, __LINE__-5, __LINE__-3].join('|')}):"o =~ t} if $@ + + if r && target.respond_to?(m) + target.__send__(m, *args, &block) + elsif ::Kernel.respond_to?(m, true) + ::Kernel.instance_method(m).bind(self).(*args, &block) + else + super(m, *args, &block) end end @@ -340,11 +337,7 @@ end def Delegator.delegating_block(mid) # :nodoc: lambda do |*args, &block| target = self.__getobj__ - begin - target.__send__(mid, *args, &block) - ensure - $@.delete_if {|t| /\A#{Regexp.quote(__FILE__)}:#{__LINE__-2}:/o =~ t} if $@ - end + target.__send__(mid, *args, &block) end end