1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve ArgumentError message for Module#set_temporary_name

Browse Source
This commit is contained in:
Benoit Daloze 2023-07-06 16:34:28 +02:00
parent 9ee1877e4a
commit 055f7219bc
Notes: git 2023-07-06 16:27:34 +00:00 
Merged: https://github.com/ruby/ruby/pull/8035
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/ruby/core/module/set_temporary_name_spec.rb
View File

@ -29,14 +29,14 @@ ruby_version_is "3.3" do
it "can't assign a constant name as a temporary name" do it "can't assign a constant name as a temporary name" do
m = Module.new m = Module.new
-> { m.set_temporary_name("Object") }.should raise_error(ArgumentError, "name must not be valid constant path") -> { m.set_temporary_name("Object") }.should raise_error(ArgumentError, "the temporary name must not be a constant path to avoid confusion")
end end
it "can't assign a constant path as a temporary name" do it "can't assign a constant path as a temporary name" do
m = Module.new m = Module.new
-> { m.set_temporary_name("A::B") }.should raise_error(ArgumentError, "name must not be valid constant path") -> { m.set_temporary_name("A::B") }.should raise_error(ArgumentError, "the temporary name must not be a constant path to avoid confusion")
-> { m.set_temporary_name("::A") }.should raise_error(ArgumentError, "name must not be valid constant path") -> { m.set_temporary_name("::A") }.should raise_error(ArgumentError, "the temporary name must not be a constant path to avoid confusion")
-> { m.set_temporary_name("::A::B") }.should raise_error(ArgumentError, "name must not be valid constant path") -> { m.set_temporary_name("::A::B") }.should raise_error(ArgumentError, "the temporary name must not be a constant path to avoid confusion")
end end
it "can't assign name to permanent module" do it "can't assign name to permanent module" do

2
variable.c
View File

@ -230,7 +230,7 @@ rb_mod_set_temporary_name(VALUE mod, VALUE name)
} }
if (is_constant_path(name)) { if (is_constant_path(name)) {
rb_raise(rb_eArgError, "name must not be valid constant path"); rb_raise(rb_eArgError, "the temporary name must not be a constant path to avoid confusion");
} }
// Set the temporary classpath to the given name: // Set the temporary classpath to the given name: