1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make the maximum shapes variation warning non-verbose

Browse Source 
[Feature #19538]

Since that category is not enabled by default, making it a
verbose warning is redundant. Enabling performance warning should
work with the default verbosity level.
This commit is contained in:
Jean Boussier 2023-04-18 12:36:57 +02:00 committed by Jean Boussier
parent 409a13e9ea
commit 04ee666aab
Notes: git 2023-05-03 08:44:15 +00:00 
Merged: https://github.com/ruby/ruby/pull/7733
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
shape.c
View File

@ -403,7 +403,7 @@ rb_shape_get_next(rb_shape_t* shape, VALUE obj, ID id)
RCLASS_EXT(klass)->variation_count++;
if (rb_warning_category_enabled_p(RB_WARN_CATEGORY_PERFORMANCE)) {
if (RCLASS_EXT(klass)->variation_count >= SHAPE_MAX_VARIATIONS) {
rb_category_warning(
rb_category_warn(
RB_WARN_CATEGORY_PERFORMANCE,
"Maximum shapes variations (%d) reached by %"PRIsVALUE", instance variables accesses will be slower.",
SHAPE_MAX_VARIATIONS,

2
test/ruby/test_object.rb
View File

@ -424,7 +424,7 @@ class TestObject < Test::Unit::TestCase
def test_max_shape_variation_with_performance_warnings
assert_in_out_err([], <<-INPUT, %w(), /Maximum shapes variations \(8\) reached by Foo, instance variables accesses will be slower\.$/)
$VERBOSE = true
$VERBOSE = false
Warning[:performance] = true
class Foo; end