1berry/ruby
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Preserve errno in rb_fiber_scheduler_unblock. (#12576)

Browse Source 
[Bug #21038]

Co-authored-by: Julian Scheid <julians37@gmail.com>
This commit is contained in:
Samuel Williams 2025-01-15 14:59:46 +13:00 committed by GitHub
parent cb419e3912
commit 04ec077946
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
Notes: git 2025-01-15 02:00:05 +00:00 
Merged-By: ioquatix <samuel@codeotaku.com>
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
scheduler.c
View File

@ -412,7 +412,15 @@ rb_fiber_scheduler_unblock(VALUE scheduler, VALUE blocker, VALUE fiber)
{
RUBY_ASSERT(rb_obj_is_fiber(fiber));
return rb_funcall(scheduler, id_unblock, 2, blocker, fiber);
// `rb_fiber_scheduler_unblock` can be called from points where `errno` is expected to be preserved. Therefore, we should save and restore it. For example `io_binwrite` calls `rb_fiber_scheduler_unblock` and if `errno` is reset to 0 by user code, it will break the error handling in `io_write`.
// If we explicitly preserve `errno` in `io_binwrite` and other similar functions (e.g. by returning it), this code is no longer needed. I hope in the future we will be able to remove it.
int saved_errno = errno;
VALUE result = rb_funcall(scheduler, id_unblock, 2, blocker, fiber);
errno = saved_errno;
return result;
}
/*