qtbase/src/corelib/kernel/qpointer.h
Marc Mutz 1219dbcd12 QPointer: ensure construction from nullptr is constinit'able
Construction from nullptr wasn't, before, because it was using the
QPointer(T*) constructor, which cannot be constexpr. Add a constexpr
QPointer(std::nullptr_t) constructor to enable this use-case.

This requires to mark the (T*) constructor as Q_WEAK_OVERLOAD,
otherwise legacy construction from a literal 0 would be ambiguous.

No documentation changes needed, as the set of valid expressions
(apart from constinit'ing) has not changed. Mention the nullptr ctor,
though, without \since.

Add a test to confirm that contruction from derived still works.

Change-Id: If9d5281f6eca0c408a69f03fecba64a70a0c9cf0
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
2023-10-05 20:19:40 +02:00

130 lines
3.8 KiB
C++

// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
#ifndef QPOINTER_H
#define QPOINTER_H
#include <QtCore/qsharedpointer.h>
#include <QtCore/qtypeinfo.h>
#ifndef QT_NO_QOBJECT
QT_BEGIN_NAMESPACE
class QVariant;
template <class T>
class QPointer
{
static_assert(!std::is_pointer<T>::value, "QPointer's template type must not be a pointer type");
template <typename X>
using if_convertible = std::enable_if_t<std::is_convertible_v<X*, T*>, bool>;
template <typename X>
friend class QPointer;
using QObjectType =
typename std::conditional<std::is_const<T>::value, const QObject, QObject>::type;
QWeakPointer<QObjectType> wp;
public:
Q_NODISCARD_CTOR
QPointer() noexcept = default;
Q_NODISCARD_CTOR
constexpr QPointer(std::nullptr_t) noexcept : QPointer{} {}
Q_WEAK_OVERLOAD
Q_NODISCARD_CTOR
inline QPointer(T *p) : wp(p, true) { }
// compiler-generated copy/move ctor/assignment operators are fine!
// compiler-generated dtor is fine!
template <typename X, if_convertible<X> = true>
Q_NODISCARD_CTOR
QPointer(QPointer<X> &&other) noexcept
: wp(std::exchange(other.wp, nullptr).internalData(), true) {}
template <typename X, if_convertible<X> = true>
Q_NODISCARD_CTOR
QPointer(const QPointer<X> &other) noexcept
: wp(other.wp.internalData(), true) {}
template <typename X, if_convertible<X> = true>
QPointer &operator=(const QPointer<X> &other) noexcept
{
QPointer(other).swap(*this);
return *this;
}
template <typename X, if_convertible<X> = true>
QPointer &operator=(QPointer<X> &&other) noexcept
{
QPointer(std::move(other)).swap(*this);
return *this;
}
#ifdef Q_QDOC
// Stop qdoc from complaining about missing function
~QPointer();
#endif
inline void swap(QPointer &other) noexcept { wp.swap(other.wp); }
inline QPointer<T> &operator=(T* p)
{ wp.assign(static_cast<QObjectType*>(p)); return *this; }
T* data() const noexcept
{ return static_cast<T*>(wp.internalData()); }
T* get() const noexcept
{ return data(); }
T* operator->() const noexcept
{ return data(); }
T& operator*() const noexcept
{ return *data(); }
operator T*() const noexcept
{ return data(); }
bool isNull() const noexcept
{ return wp.isNull(); }
void clear() noexcept
{ wp.clear(); }
friend void swap(QPointer &lhs, QPointer &rhs) noexcept
{ lhs.swap(rhs); }
#define DECLARE_COMPARE_SET(T1, A1, T2, A2) \
friend bool operator==(T1, T2) noexcept \
{ return A1 == A2; } \
friend bool operator!=(T1, T2) noexcept \
{ return A1 != A2; }
#define DECLARE_TEMPLATE_COMPARE_SET(T1, A1, T2, A2) \
template <typename X> \
friend bool operator==(T1, T2) noexcept \
{ return A1 == A2; } \
template <typename X> \
friend bool operator!=(T1, T2) noexcept \
{ return A1 != A2; }
DECLARE_TEMPLATE_COMPARE_SET(const QPointer &p1, p1.data(), const QPointer<X> &p2, p2.data())
DECLARE_TEMPLATE_COMPARE_SET(const QPointer &p1, p1.data(), X *ptr, ptr)
DECLARE_TEMPLATE_COMPARE_SET(X *ptr, ptr, const QPointer &p2, p2.data())
DECLARE_COMPARE_SET(const QPointer &p1, p1.data(), std::nullptr_t, nullptr)
DECLARE_COMPARE_SET(std::nullptr_t, nullptr, const QPointer &p2, p2.data())
#undef DECLARE_COMPARE_SET
#undef DECLARE_TEMPLATE_COMPARE_SET
};
template <class T> Q_DECLARE_TYPEINFO_BODY(QPointer<T>, Q_RELOCATABLE_TYPE);
template<typename T>
QPointer<T>
qPointerFromVariant(const QVariant &variant)
{
const auto wp = QtSharedPointer::weakPointerFromVariant_internal(variant);
return QPointer<T>{qobject_cast<T*>(QtPrivate::EnableInternalData::internalData(wp))};
}
QT_END_NAMESPACE
#endif // QT_NO_QOBJECT
#endif // QPOINTER_H