4809d41e67
setFloating() called on the 2nd last dock widget in a floating tab didn't cause reparenting to the main window. The dock widget remained parented to a QDockWidgetGroupWindow, while no longer being part of floating tabs. The QDockWidgetGroupWindow would therefore have only one tab, which is an inconsistent state and causes crashes. Factor out the implementation of setFloating() to a new QDockWidgetPrivate::setFloating(). Reparent to the main window, if the dock widget is part of floating tabs. Add test functionality in tst_QDockWidget::setFloating(). Turn createFloatingTabs() into a macro, in order to QSKIP() in the test function's scope. Fixes: QTBUG-122394 Pick-to: 6.5 Change-Id: I3719785f310b131446cdea908f09b7195c992b3e Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit a910daf52678469b7e595da5fe54aa09ba2373c3) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This directory contains autotests and benchmarks based on Qt Test. In order
to run the autotests reliably, you need to configure a desktop to match the
test environment that these tests are written for.
Linux X11:
* The user must be logged in to an active desktop; you can't run the
autotests without a valid DISPLAY that allows X11 connections.
* The tests are run against a KDE3 or KDE4 desktop.
* Window manager uses "click to focus", and not "focus follows mouse". Many
tests move the mouse cursor around and expect this to not affect focus
and activation.
* Disable "click to activate", i.e., when a window is opened, the window
manager should automatically activate it (give it input focus) and not
wait for the user to click the window.