[ChangeLog][QtCore] Introduced Q_NODISCARD_CTOR which resolves to [[nodiscard]] attribute for constructors on compilers that support it, and does nothing on other compilers. Using [[nodiscard]] attribute on a constructor is a C++20 feature, however in practice it is supported on most of the compilers that we use in Qt 6. Clang generates a [-Wunused-value] warning, GCC and MinGW generate a [-Wunused-result] warnings, and MSVC generates a C4834 warning. However, there are some exceptions. The Integrity compiler provides the following warning: "tst_qglobal.cpp", line 699: warning #3435-D: the "nodiscard" attribute doesn't apply to constructors, destructors, or routines with void return type [[nodiscard]] explicit Test(int val) : m_val(val) {} The QNX compiler (QCC 8.3.0) and GCC 9.3.1 on OpenSUSE generate the [-Wattributes] warning: tst_qglobal.cpp: In member function 'void tst_QGlobal::nodiscardConstructor()': tst_qglobal.cpp:699:44: warning: 'nodiscard' attribute applied to 'tst_QGlobal::nodiscardConstructor()::Test::Test(int)' with void return type [-Wattributes] [[nodiscard]] explicit Test(int val) : m_val(val) {} These warnings will lead to build failures when compiled with -warnings-are-errors flag, so for these compilers the macro does not do anything. An attempt to use __attribute__((__warn_unused_result__)) was also unsuccessful on these compilers, so this patch goes for an easy solution, and simply checks __has_cpp_attribute(nodiscard) >= 201907L to decide if the attribute is supported or not. This commit also introduces a syntax-only test, and also applies the new macro to QMutexLocker, because not all platforms in the CI build and run unit tests. Fixes: QTBUG-104161 Change-Id: Ib4230661a5ad5e8af0d67b21b034486ebcd67562 Reviewed-by: Marc Mutz <marc.mutz@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
350 lines
8.5 KiB
C++
350 lines
8.5 KiB
C++
// Copyright (C) 2016 The Qt Company Ltd.
|
|
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR LGPL-3.0-only OR GPL-2.0-only OR GPL-3.0-only
|
|
|
|
#ifndef QMUTEX_H
|
|
#define QMUTEX_H
|
|
|
|
#include <QtCore/qglobal.h>
|
|
#include <QtCore/qatomic.h>
|
|
#include <QtCore/qtsan_impl.h>
|
|
#include <new>
|
|
|
|
#include <chrono>
|
|
#include <limits>
|
|
|
|
class tst_QMutex;
|
|
|
|
QT_BEGIN_NAMESPACE
|
|
|
|
|
|
#if QT_CONFIG(thread) || defined(Q_QDOC)
|
|
|
|
#if defined(Q_OS_LINUX) || defined(Q_OS_WIN) // these platforms use futex
|
|
# define QT_MUTEX_LOCK_NOEXCEPT noexcept
|
|
#else
|
|
# define QT_MUTEX_LOCK_NOEXCEPT
|
|
#endif
|
|
|
|
class QMutex;
|
|
class QRecursiveMutex;
|
|
class QMutexPrivate;
|
|
|
|
namespace QtPrivate
|
|
{
|
|
template<class Rep, class Period>
|
|
static int convertToMilliseconds(std::chrono::duration<Rep, Period> duration)
|
|
{
|
|
// N4606 § 30.4.1.3.5 [thread.timedmutex.requirements] specifies that a
|
|
// duration less than or equal to duration.zero() shall result in a
|
|
// try_lock, unlike QMutex's tryLock with a negative duration which
|
|
// results in a lock.
|
|
|
|
if (duration <= duration.zero())
|
|
return 0;
|
|
|
|
// when converting from 'duration' to milliseconds, make sure that
|
|
// the result is not shorter than 'duration':
|
|
std::chrono::milliseconds wait = std::chrono::duration_cast<std::chrono::milliseconds>(duration);
|
|
if (wait < duration)
|
|
wait += std::chrono::milliseconds(1);
|
|
Q_ASSERT(wait >= duration);
|
|
const auto ms = wait.count();
|
|
const auto maxInt = (std::numeric_limits<int>::max)();
|
|
|
|
return ms < maxInt ? int(ms) : maxInt;
|
|
}
|
|
}
|
|
|
|
class Q_CORE_EXPORT QBasicMutex
|
|
{
|
|
Q_DISABLE_COPY_MOVE(QBasicMutex)
|
|
public:
|
|
constexpr QBasicMutex()
|
|
: d_ptr(nullptr)
|
|
{}
|
|
|
|
// BasicLockable concept
|
|
inline void lock() QT_MUTEX_LOCK_NOEXCEPT {
|
|
QtTsan::mutexPreLock(this, 0u);
|
|
|
|
if (!fastTryLock())
|
|
lockInternal();
|
|
|
|
QtTsan::mutexPostLock(this, 0u, 0);
|
|
}
|
|
|
|
// BasicLockable concept
|
|
inline void unlock() noexcept {
|
|
Q_ASSERT(d_ptr.loadRelaxed()); //mutex must be locked
|
|
|
|
QtTsan::mutexPreUnlock(this, 0u);
|
|
|
|
if (!fastTryUnlock())
|
|
unlockInternal();
|
|
|
|
QtTsan::mutexPostUnlock(this, 0u);
|
|
}
|
|
|
|
bool tryLock() noexcept {
|
|
unsigned tsanFlags = QtTsan::TryLock;
|
|
QtTsan::mutexPreLock(this, tsanFlags);
|
|
|
|
const bool success = fastTryLock();
|
|
|
|
if (!success)
|
|
tsanFlags |= QtTsan::TryLockFailed;
|
|
QtTsan::mutexPostLock(this, tsanFlags, 0);
|
|
|
|
return success;
|
|
}
|
|
|
|
// Lockable concept
|
|
bool try_lock() noexcept { return tryLock(); }
|
|
|
|
private:
|
|
inline bool fastTryLock() noexcept {
|
|
return d_ptr.testAndSetAcquire(nullptr, dummyLocked());
|
|
}
|
|
inline bool fastTryUnlock() noexcept {
|
|
return d_ptr.testAndSetRelease(dummyLocked(), nullptr);
|
|
}
|
|
|
|
void lockInternal() QT_MUTEX_LOCK_NOEXCEPT;
|
|
bool lockInternal(int timeout) QT_MUTEX_LOCK_NOEXCEPT;
|
|
void unlockInternal() noexcept;
|
|
void destroyInternal(QMutexPrivate *d);
|
|
|
|
QBasicAtomicPointer<QMutexPrivate> d_ptr;
|
|
static inline QMutexPrivate *dummyLocked() {
|
|
return reinterpret_cast<QMutexPrivate *>(quintptr(1));
|
|
}
|
|
|
|
friend class QMutex;
|
|
friend class QMutexPrivate;
|
|
};
|
|
|
|
class Q_CORE_EXPORT QMutex : public QBasicMutex
|
|
{
|
|
public:
|
|
constexpr QMutex() = default;
|
|
~QMutex()
|
|
{
|
|
QMutexPrivate *d = d_ptr.loadRelaxed();
|
|
if (d)
|
|
destroyInternal(d);
|
|
}
|
|
|
|
#ifdef Q_QDOC
|
|
inline void lock() QT_MUTEX_LOCK_NOEXCEPT;
|
|
inline void unlock() noexcept;
|
|
bool tryLock() noexcept;
|
|
#endif
|
|
|
|
// Lockable concept
|
|
bool try_lock() noexcept { return tryLock(); }
|
|
|
|
|
|
using QBasicMutex::tryLock;
|
|
bool tryLock(int timeout) QT_MUTEX_LOCK_NOEXCEPT
|
|
{
|
|
unsigned tsanFlags = QtTsan::TryLock;
|
|
QtTsan::mutexPreLock(this, tsanFlags);
|
|
|
|
bool success = fastTryLock();
|
|
|
|
if (success) {
|
|
QtTsan::mutexPostLock(this, tsanFlags, 0);
|
|
return success;
|
|
}
|
|
|
|
success = lockInternal(timeout);
|
|
|
|
if (!success)
|
|
tsanFlags |= QtTsan::TryLockFailed;
|
|
QtTsan::mutexPostLock(this, tsanFlags, 0);
|
|
|
|
return success;
|
|
}
|
|
|
|
// TimedLockable concept
|
|
template <class Rep, class Period>
|
|
bool try_lock_for(std::chrono::duration<Rep, Period> duration)
|
|
{
|
|
return tryLock(QtPrivate::convertToMilliseconds(duration));
|
|
}
|
|
|
|
// TimedLockable concept
|
|
template<class Clock, class Duration>
|
|
bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint)
|
|
{
|
|
// Implemented in terms of try_lock_for to honor the similar
|
|
// requirement in N4606 § 30.4.1.3 [thread.timedmutex.requirements]/12.
|
|
|
|
return try_lock_for(timePoint - Clock::now());
|
|
}
|
|
};
|
|
|
|
class Q_CORE_EXPORT QRecursiveMutex
|
|
{
|
|
Q_DISABLE_COPY_MOVE(QRecursiveMutex)
|
|
// written to by the thread that first owns 'mutex';
|
|
// read during attempts to acquire ownership of 'mutex' from any other thread:
|
|
QAtomicPointer<void> owner = nullptr;
|
|
// only ever accessed from the thread that owns 'mutex':
|
|
uint count = 0;
|
|
QMutex mutex;
|
|
|
|
public:
|
|
constexpr QRecursiveMutex() = default;
|
|
~QRecursiveMutex();
|
|
|
|
|
|
// BasicLockable concept
|
|
void lock() QT_MUTEX_LOCK_NOEXCEPT
|
|
{ tryLock(-1); }
|
|
bool tryLock(int timeout = 0) QT_MUTEX_LOCK_NOEXCEPT;
|
|
// BasicLockable concept
|
|
void unlock() noexcept;
|
|
|
|
// Lockable concept
|
|
bool try_lock() QT_MUTEX_LOCK_NOEXCEPT { return tryLock(); }
|
|
|
|
// TimedLockable concept
|
|
template <class Rep, class Period>
|
|
bool try_lock_for(std::chrono::duration<Rep, Period> duration)
|
|
{
|
|
return tryLock(QtPrivate::convertToMilliseconds(duration));
|
|
}
|
|
|
|
// TimedLockable concept
|
|
template<class Clock, class Duration>
|
|
bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint)
|
|
{
|
|
// Implemented in terms of try_lock_for to honor the similar
|
|
// requirement in N4606 § 30.4.1.3 [thread.timedmutex.requirements]/12.
|
|
|
|
return try_lock_for(timePoint - Clock::now());
|
|
}
|
|
};
|
|
|
|
template <typename Mutex>
|
|
class [[nodiscard]] QMutexLocker
|
|
{
|
|
public:
|
|
Q_NODISCARD_CTOR
|
|
inline explicit QMutexLocker(Mutex *mutex) QT_MUTEX_LOCK_NOEXCEPT
|
|
{
|
|
m_mutex = mutex;
|
|
if (Q_LIKELY(mutex)) {
|
|
mutex->lock();
|
|
m_isLocked = true;
|
|
}
|
|
}
|
|
|
|
Q_NODISCARD_CTOR
|
|
inline QMutexLocker(QMutexLocker &&other) noexcept
|
|
: m_mutex(std::exchange(other.m_mutex, nullptr)),
|
|
m_isLocked(std::exchange(other.m_isLocked, false))
|
|
{}
|
|
|
|
QT_MOVE_ASSIGNMENT_OPERATOR_IMPL_VIA_MOVE_AND_SWAP(QMutexLocker)
|
|
|
|
inline ~QMutexLocker()
|
|
{
|
|
if (m_isLocked)
|
|
unlock();
|
|
}
|
|
|
|
inline bool isLocked() const noexcept
|
|
{
|
|
return m_isLocked;
|
|
}
|
|
|
|
inline void unlock() noexcept
|
|
{
|
|
Q_ASSERT(m_isLocked);
|
|
m_mutex->unlock();
|
|
m_isLocked = false;
|
|
}
|
|
|
|
inline void relock() QT_MUTEX_LOCK_NOEXCEPT
|
|
{
|
|
Q_ASSERT(!m_isLocked);
|
|
m_mutex->lock();
|
|
m_isLocked = true;
|
|
}
|
|
|
|
inline void swap(QMutexLocker &other) noexcept
|
|
{
|
|
qt_ptr_swap(m_mutex, other.m_mutex);
|
|
std::swap(m_isLocked, other.m_isLocked);
|
|
}
|
|
|
|
Mutex *mutex() const
|
|
{
|
|
return m_mutex;
|
|
}
|
|
private:
|
|
Q_DISABLE_COPY(QMutexLocker)
|
|
|
|
Mutex *m_mutex;
|
|
bool m_isLocked = false;
|
|
};
|
|
|
|
#else // !QT_CONFIG(thread) && !Q_QDOC
|
|
|
|
class QMutex
|
|
{
|
|
public:
|
|
|
|
constexpr QMutex() noexcept { }
|
|
|
|
inline void lock() noexcept {}
|
|
inline bool tryLock(int timeout = 0) noexcept { Q_UNUSED(timeout); return true; }
|
|
inline bool try_lock() noexcept { return true; }
|
|
inline void unlock() noexcept {}
|
|
|
|
template <class Rep, class Period>
|
|
inline bool try_lock_for(std::chrono::duration<Rep, Period> duration) noexcept
|
|
{
|
|
Q_UNUSED(duration);
|
|
return true;
|
|
}
|
|
|
|
template<class Clock, class Duration>
|
|
inline bool try_lock_until(std::chrono::time_point<Clock, Duration> timePoint) noexcept
|
|
{
|
|
Q_UNUSED(timePoint);
|
|
return true;
|
|
}
|
|
|
|
private:
|
|
Q_DISABLE_COPY(QMutex)
|
|
};
|
|
|
|
class QRecursiveMutex : public QMutex {};
|
|
|
|
template <typename Mutex>
|
|
class [[nodiscard]] QMutexLocker
|
|
{
|
|
public:
|
|
Q_NODISCARD_CTOR
|
|
inline explicit QMutexLocker(Mutex *) noexcept {}
|
|
inline ~QMutexLocker() noexcept {}
|
|
|
|
inline void unlock() noexcept {}
|
|
void relock() noexcept {}
|
|
inline Mutex *mutex() const noexcept { return nullptr; }
|
|
|
|
private:
|
|
Q_DISABLE_COPY(QMutexLocker)
|
|
};
|
|
|
|
typedef QMutex QBasicMutex;
|
|
|
|
#endif // !QT_CONFIG(thread) && !Q_QDOC
|
|
|
|
QT_END_NAMESPACE
|
|
|
|
#endif // QMUTEX_H
|