QtLoader doesn't really handle failures in a way that's visible outside the class itself. There is the abstract finish() method subclasses can implement to handle clean up in the loader itself, but it's not visible outside, which leads to trying to execute paths of code we know are not going to work, since if the Qt libraries are not loaded the Qt app is not going to work. Make QtLoader throw an exception if invalid arguments are passed to it, as there is no way for the loader to do its job properly if the passed Context is not what we expect it to be, so might as well exit early. Make the loadQtLibraries() method return a boolean, letting the caller know whether the loading was successful or not. As a result, the finish() method can be removed, and the caller can handle failure as appropriate for it. Task-number: QTBUG-124114 Change-Id: I2dc1a0846eb404112f88e9da365db2ab071f4317 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> (cherry picked from commit 2b48614f68cbf98d6597819749b732556c32cb44) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
…
Description
Languages
C++
84.3%
HTML
4.9%
C
3.9%
CMake
3.6%
Objective-C++
2%
Other
0.8%