4daef13af8
If an inline member function is defined outside of its class' body, its declaration must have the inline keyword. Otherwise, in certain situations, MinGW complains like this: qstring.h:1118:13: error: 'void QString::clear()' redeclared without dllimport attribute after being referenced with dll linkage [-Werror] Fix all instances in qstring.h by - adding the inline keyword where it was missing on the definition (except constexpr functions, which are implicitly inline) - removing the inline keyword from all out-of-class-body definitions While the latter isn't necessary for fixing the MinGW warning-turned-error, the churn is warranted: It's enlisting all platforms' help in checking for inline consistency (by causing "multiple-definition errors" at link time or "inline function never defined" at compile time when we get it wrong). If we kept the inline keyword on the definitions, only MinGW would continue to warn, and only in some, as of yet not fully understood, situations, so we'd have no control over when these warnings pop up in user code. Change-Id: I0ae78f1d8f1fa4eaec0b162ea16013669370eead Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> Reviewed-by: Dennis Oberst <dennis.oberst@qt.io> Reviewed-by: Ivan Solovev <ivan.solovev@qt.io> (cherry picked from commit 1c1d7ab486b87489163c56b05d10ff907e1d821d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>