From ffb81e62704f72b61ead213abed708008762004f Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Mon, 24 Mar 2025 14:54:31 -0700 Subject: [PATCH] QFileSystemEngine/Unix: remove superfluous setting of knownFlagsMask fillFromStatBuf() and fillFromStatxBuf() (through flagsFromStMode()) set the PosixStatFlags, ExistsAttribute, and sometimes HiddenAttribute. It's harmless to set the same bits again, but we can do slightly better. Change-Id: I1def9449b4ba10fbcd49fffd0fe6fc8734d0b3bd Reviewed-by: Edward Welbourne --- src/corelib/io/qfilesystemengine_unix.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/corelib/io/qfilesystemengine_unix.cpp b/src/corelib/io/qfilesystemengine_unix.cpp index 25bdcc75312..3dcca8e264c 100644 --- a/src/corelib/io/qfilesystemengine_unix.cpp +++ b/src/corelib/io/qfilesystemengine_unix.cpp @@ -944,9 +944,6 @@ bool QFileSystemEngine::fillMetaData(const QFileSystemEntry &entry, QFileSystemM data.fillFromStatxBuf(statxBuffer); else data.fillFromStatBuf(statBuffer); - data.knownFlagsMask |= QFileSystemMetaData::PosixStatFlags - | QFileSystemMetaData::ExistsAttribute; - data.entryFlags |= QFileSystemMetaData::ExistsAttribute; } } else { // it doesn't exist @@ -981,11 +978,11 @@ bool QFileSystemEngine::fillMetaData(const QFileSystemEntry &entry, QFileSystemM data.size_ = 0; data.userId_ = (uint) -2; data.groupId_ = (uint) -2; - } - // reset the mask - data.knownFlagsMask |= QFileSystemMetaData::PosixStatFlags - | QFileSystemMetaData::ExistsAttribute; + // reset the mask + data.knownFlagsMask |= QFileSystemMetaData::PosixStatFlags + | QFileSystemMetaData::ExistsAttribute; + } } // third, we try access(2)