1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Document that our CSS parser cannot parse unquoted URLs with query

Browse Source 
Add test data rows with failing strings.

Task-number: QTBUG-131842
Change-Id: Ifa56d0a60ee2220f4a75ca71ebef375412a79d40
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
This commit is contained in:
Volker Hilsheimer 2024-12-03 16:13:36 +01:00
parent 24d3a2fa48
commit fe76b9e479
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/auto/gui/text/qcssparser/tst_qcssparser.cpp
View File

@ -294,9 +294,13 @@ void tst_QCssParser::term_data()
val.type = QCss::Value::Uri;
val.variant = QString("www.kde.org");
QTest::newRow("uri1") << true << "url(\"www.kde.org\")" << val;
QTest::newRow("uri2") << true << "url(www.kde.org)" << val;
val.type = QCss::Value::Uri;
val.variant = QString("www.kde.org/test?key=value&v=123");
QTest::newRow("uri_query_quoted") << true << "url(\"www.kde.org/test?key=value&v=123\")" << val;
QTest::newRow("uri_query_unquoted") << true << "url(www.kde.org/test?key=value&v=123)" << val;
val.type = QCss::Value::KnownIdentifier;
val.variant = int(QCss::Value_Italic);
QTest::newRow("italic") << true << "italic" << val;
@ -315,6 +319,7 @@ void tst_QCssParser::term()
QCss::Parser parser(css);
QCss::Value val;
QVERIFY(parser.testTerm());
QEXPECT_FAIL("uri_query_unquoted", "QTBUG-131842", Abort);
QCOMPARE(parser.parseTerm(&val), parseSuccess);
if (parseSuccess) {
QCOMPARE(int(val.type), int(expectedValue.type));
@ -1411,6 +1416,12 @@ void tst_QCssParser::shorthandBackgroundProperty_data()
QTest::newRow("multi") << "background: left url(blah.png) repeat-x" << QBrush() << QString("blah.png") << int(QCss::Repeat_X) << int(Qt::AlignLeft | Qt::AlignVCenter);
QTest::newRow("multi2") << "background: url(blah.png) repeat-x top" << QBrush() << QString("blah.png") << int(QCss::Repeat_X) << int(Qt::AlignTop | Qt::AlignHCenter);
QTest::newRow("multi3") << "background: url(blah.png) top right" << QBrush() << QString("blah.png") << int(QCss::Repeat_XY) << int(Qt::AlignTop | Qt::AlignRight);
QTest::newRow("url-query-quoted") << "background: url(\"https://placecats.com/300/200?fit=contain&position=top\")"
<< QBrush() << QString("https://placecats.com/300/200?fit=contain&position=top")
<< int(QCss::Repeat_XY) << int(Qt::AlignTop | Qt::AlignLeft);
QTest::newRow("url-query-unquoted") << "background: url(https://placecats.com/300/200?fit=contain&position=top)"
<< QBrush() << QString("https://placecats.com/300/200?fit=contain&position=top")
<< int(QCss::Repeat_XY) << int(Qt::AlignTop | Qt::AlignLeft);
}
void tst_QCssParser::shorthandBackgroundProperty()
@ -1425,6 +1436,7 @@ void tst_QCssParser::shorthandBackgroundProperty()
QCss::Parser parser(css);
QCss::StyleSheet sheet;
QEXPECT_FAIL("url-query-unquoted", "QTBUG-131842", Abort);
QVERIFY(parser.parse(&sheet));
DomStyleSelector testSelector(doc, sheet);