From fd87c8da82b4bf52d395a5f9a2687e4eb7a22221 Mon Sep 17 00:00:00 2001
From: Kari Oikarinen <kari.oikarinen@qt.io>
Date: Tue, 3 Apr 2018 10:21:24 +0300
Subject: [PATCH] tests/auto/other: Avoid unconditional qWait()s

There is no need to qWait() before a QTRY_VERIFY. qWait() will also
intermittently handle events while waiting, so calling it in a loop isn't
necessary.

Change-Id: Ica7fbf18c03e673213dd9b72f31f71937cdcb145
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
---
 tests/auto/other/qfocusevent/tst_qfocusevent.cpp |  5 +----
 tests/auto/other/qobjectrace/tst_qobjectrace.cpp | 12 ++----------
 2 files changed, 3 insertions(+), 14 deletions(-)

diff --git a/tests/auto/other/qfocusevent/tst_qfocusevent.cpp b/tests/auto/other/qfocusevent/tst_qfocusevent.cpp
index 70e696e7036..37521a64aa8 100644
--- a/tests/auto/other/qfocusevent/tst_qfocusevent.cpp
+++ b/tests/auto/other/qfocusevent/tst_qfocusevent.cpp
@@ -196,7 +196,6 @@ void tst_QFocusEvent::checkReason_BackTab()
 
     // Now test the backtab key
     QTest::keyClick( childFocusWidgetOne, Qt::Key_Backtab );
-    QTest::qWait(200);
 
     QTRY_VERIFY(childFocusWidgetOne->focusOutEventRecieved);
     QVERIFY(childFocusWidgetTwo->focusInEventRecieved);
@@ -217,7 +216,6 @@ void tst_QFocusEvent::checkReason_Popup()
     QMenu* popupMenu = new QMenu( testFocusWidget );
     popupMenu->addMenu( "Test" );
     popupMenu->popup( QPoint(0,0) );
-    QTest::qWait(50);
 
     QTRY_VERIFY(childFocusWidgetOne->focusOutEventLostFocus);
 
@@ -308,7 +306,7 @@ void tst_QFocusEvent::checkReason_focusWidget()
     window1.show();
 
     edit1.setFocus();
-    QTest::qWait(100);
+    QTRY_VERIFY(edit1.hasFocus());
     edit2.setFocus();
 
     QVERIFY(frame1.focusWidget() != 0);
@@ -344,7 +342,6 @@ void tst_QFocusEvent::checkReason_ActiveWindow()
     QVERIFY( !childFocusWidgetOne->hasFocus() );
 
     d->hide();
-    QTest::qWait(100);
 
     if (!QGuiApplication::platformName().compare(QLatin1String("offscreen"), Qt::CaseInsensitive)
         || !QGuiApplication::platformName().compare(QLatin1String("minimal"), Qt::CaseInsensitive)) {
diff --git a/tests/auto/other/qobjectrace/tst_qobjectrace.cpp b/tests/auto/other/qobjectrace/tst_qobjectrace.cpp
index aa78d707162..e6eb51500ba 100644
--- a/tests/auto/other/qobjectrace/tst_qobjectrace.cpp
+++ b/tests/auto/other/qobjectrace/tst_qobjectrace.cpp
@@ -420,11 +420,7 @@ void tst_QObjectRace::disconnectRace()
             threads[i]->start();
         }
 
-        QTime timeLimiter;
-        timeLimiter.start();
-
-        while (timeLimiter.elapsed() < TimeLimit)
-            QTest::qWait(10);
+        QTest::qWait(TimeLimit);
 
         for (int i = 0; i < ThreadCount; ++i) {
             threads[i]->requestInterruption();
@@ -450,11 +446,7 @@ void tst_QObjectRace::disconnectRace()
             threads[i]->start();
         }
 
-        QTime timeLimiter;
-        timeLimiter.start();
-
-        while (timeLimiter.elapsed() < TimeLimit)
-            QTest::qWait(10);
+        QTest::qWait(TimeLimit);
 
         senderThread->requestInterruption();
         QVERIFY(senderThread->wait(300));