1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Doc: add missing doc for parameters

Browse Source 
qhstspolicy.cpp:105: warning: Undocumented parameter 'flags' in QHstsPolicy::QHstsPolicy()
qhstspolicy.cpp:105: warning: No such parameter 'includeSubDomains' in QHstsPolicy::QHstsPolicy()
qnetworkaccessmanager.cpp:732: warning: Undocumented parameter 'knownHosts' in QNetworkAccessManager::addStrictTransportSecurityHosts()

Change-Id: I24217d328df12febab30e19e2abd351e87007959
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
This commit is contained in:
Nico Vertriest 2017-04-11 12:13:51 +02:00
parent 8b62673d9f
commit fc2f0fb390
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/network/access/qhstspolicy.cpp
View File

@ -103,11 +103,11 @@ QHstsPolicy::QHstsPolicy() : d(new QHstsPolicyPrivate)
} }
/*! /*!
Constructs QHstsPolicy with \a expiry (in UTC); \a includeSubDomains parameter Constructs QHstsPolicy with \a expiry (in UTC):
defines if this policy must also include subdomains, \a host data is interpreted - \a host data is interpreted according to \a mode;
according to \a mode. - \a flags selects options to apply to this policy.
\sa QUrl::setHost(), QUrl::ParsingMode \sa QUrl::setHost(), QUrl::ParsingMode, QHstsPolicy::PolicyFlag
*/ */
QHstsPolicy::QHstsPolicy(const QDateTime &expiry, PolicyFlags flags, QHstsPolicy::QHstsPolicy(const QDateTime &expiry, PolicyFlags flags,
const QString &host, QUrl::ParsingMode mode) const QString &host, QUrl::ParsingMode mode)

2
src/network/access/qnetworkaccessmanager.cpp
View File

@ -739,7 +739,7 @@ bool QNetworkAccessManager::isStrictTransportSecurityEnabled() const
\note While processing HTTP responses, QNetworkAccessManager can also update \note While processing HTTP responses, QNetworkAccessManager can also update
the HSTS cache, removing or updating exitsting policies or introducing new the HSTS cache, removing or updating exitsting policies or introducing new
known hosts. The current implementation thus is server-driven, client code \a knownHosts. The current implementation thus is server-driven, client code
can provide QNetworkAccessManager with previously known or discovered can provide QNetworkAccessManager with previously known or discovered
policies, but this information can be overridden by "Strict-Transport-Security" policies, but this information can be overridden by "Strict-Transport-Security"
response headers. response headers.