1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QHttp2Connection: Send error for CONTINUATION without preceding data

Browse Source 
Send connection error type PROTOCOL_ERROR when receivng CONTINUATION
frames without any data received from previous HEADERS or PUSH_PROMISE
frames, instead of assert.

Task-number: QTBUG-122375
Change-Id: Ib14e4610692dc4832b1f3e99dca497d9baf3d9d3
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 89467428f8173524083fd7d2cca9c2985141d567)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Øystein Heskestad 2024-03-15 16:13:56 +01:00 committed by Qt Cherry-pick Bot
parent bf7eff0188
commit fbdcae954e
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/network/access/qhttp2connection.cpp
View File

@ -1204,7 +1204,9 @@ void QHttp2Connection::handleWINDOW_UPDATE()
void QHttp2Connection::handleCONTINUATION() void QHttp2Connection::handleCONTINUATION()
{ {
Q_ASSERT(inboundFrame.type() == FrameType::CONTINUATION); Q_ASSERT(inboundFrame.type() == FrameType::CONTINUATION);
Q_ASSERT(!continuedFrames.empty()); // HEADERS frame must be already in. if (continuedFrames.empty())
return connectionError(PROTOCOL_ERROR,
"CONTINUATION without a preceding HEADERS or PUSH_PROMISE");
if (inboundFrame.streamID() != continuedFrames.front().streamID()) if (inboundFrame.streamID() != continuedFrames.front().streamID())
return connectionError(PROTOCOL_ERROR, "CONTINUATION on invalid stream"); return connectionError(PROTOCOL_ERROR, "CONTINUATION on invalid stream");