1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QDnsLookup::lookupReuse(): Rewrite using lookupCommon helper

Browse Source 
Task-number: QTBUG-129335
Change-Id: I8417ff9e76076d0b1a40270edc1b2692a122657f
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
(cherry picked from commit 41768db300b70dda36344ab1cafb6b99937da435)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Tor Arne Vestbø 2024-09-30 13:51:05 +02:00 committed by Qt Cherry-pick Bot
parent 9cd561f355
commit fb69c5a354
1 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
tests/auto/network/kernel/qdnslookup/tst_qdnslookup.cpp
View File

@ -565,28 +565,23 @@ void tst_QDnsLookup::lookupIdn()
void tst_QDnsLookup::lookupReuse()
{
QDnsLookup lookup;
// first lookup
lookup.setType(QDnsLookup::A);
lookup.setName(domainName("a-single"));
lookup.lookup();
QTRY_VERIFY_WITH_TIMEOUT(lookup.isFinished(), Timeout);
std::unique_ptr<QDnsLookup> lookup = lookupCommon(QDnsLookup::Type::A, "a-single");
QCOMPARE(int(lookup.error()), int(QDnsLookup::NoError));
QVERIFY(!lookup.hostAddressRecords().isEmpty());
QCOMPARE(lookup.hostAddressRecords().first().name(), domainName("a-single"));
QCOMPARE(lookup.hostAddressRecords().first().value(), QHostAddress("192.0.2.1"));
QCOMPARE(lookup->error(), QDnsLookup::NoError);
QVERIFY(!lookup->hostAddressRecords().isEmpty());
QCOMPARE(lookup->hostAddressRecords().first().name(), domainName("a-single"));
QCOMPARE(lookup->hostAddressRecords().first().value(), QHostAddress("192.0.2.1"));
// second lookup
lookup.setType(QDnsLookup::AAAA);
lookup.setName(domainName("aaaa-single"));
lookup.lookup();
QTRY_VERIFY_WITH_TIMEOUT(lookup.isFinished(), Timeout);
QCOMPARE(int(lookup.error()), int(QDnsLookup::NoError));
QVERIFY(!lookup.hostAddressRecords().isEmpty());
QCOMPARE(lookup.hostAddressRecords().first().name(), domainName("aaaa-single"));
QCOMPARE(lookup.hostAddressRecords().first().value(), QHostAddress("2001:db8::1"));
lookup->setType(QDnsLookup::AAAA);
lookup->setName(domainName("aaaa-single"));
lookup->lookup();
QTRY_VERIFY_WITH_TIMEOUT(lookup->isFinished(), Timeout);
QCOMPARE(lookup->error(), QDnsLookup::NoError);
QVERIFY(!lookup->hostAddressRecords().isEmpty());
QCOMPARE(lookup->hostAddressRecords().first().name(), domainName("aaaa-single"));
QCOMPARE(lookup->hostAddressRecords().first().value(), QHostAddress("2001:db8::1"));
}