1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QDockWidget: constify helper functions

Browse Source 
QMainWindowLayout::dockWidgetArea() takes a QWidget* argument. Since
it won't modify the widget, the argument should be const.

Make it const and change related indexOf() methods to also take a
const argument.

Done-with: Dheerendra Purohit <dheerendra@pthinks.com>
Task-number: QTBUG-117834
Change-Id: Id11d17f984104760851ceda2b6648284d83982d5
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
This commit is contained in:
Axel Spoerl 2024-10-28 08:52:16 +01:00
parent b8c879f273
commit fa44332f91
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/widgets/widgets/qdockarealayout.cpp
View File

@ -1474,7 +1474,7 @@ QList<int> QDockAreaLayoutInfo::indexOfPlaceHolder(const QString &objectName) co
return QList<int>();
}
QList<int> QDockAreaLayoutInfo::indexOf(QWidget *widget) const
QList<int> QDockAreaLayoutInfo::indexOf(const QWidget *widget) const
{
for (int i = 0; i < item_list.size(); ++i) {
const QDockAreaLayoutItem &item = item_list.at(i);
@ -2458,7 +2458,7 @@ QList<int> QDockAreaLayout::indexOfPlaceHolder(const QString &objectName) const
return QList<int>();
}
QList<int> QDockAreaLayout::indexOf(QWidget *dockWidget) const
QList<int> QDockAreaLayout::indexOf(const QWidget *dockWidget) const
{
for (int i = 0; i < QInternal::DockCount; ++i) {
QList<int> result = docks[i].indexOf(dockWidget);

4
src/widgets/widgets/qdockarealayout_p.h
View File

@ -143,7 +143,7 @@ public:
int next(int idx) const;
int prev(int idx) const;
QList<int> indexOf(QWidget *widget) const;
QList<int> indexOf(const QWidget *widget) const;
QList<int> indexOfPlaceHolder(const QString &objectName) const;
QDockWidget *apply(bool animate);
@ -217,7 +217,7 @@ public:
bool restoreState(QDataStream &stream, const QList<QDockWidget*> &widgets, bool testing = false);
QList<int> indexOfPlaceHolder(const QString &objectName) const;
QList<int> indexOf(QWidget *dockWidget) const;
QList<int> indexOf(const QWidget *dockWidget) const;
QList<int> gapIndex(const QPoint &pos, bool disallowTabs) const;
QList<int> findSeparator(const QPoint &pos) const;

2
src/widgets/widgets/qmainwindowlayout.cpp
View File

@ -1868,7 +1868,7 @@ void QMainWindowLayout::splitDockWidget(QDockWidget *after,
invalidate();
}
Qt::DockWidgetArea QMainWindowLayout::dockWidgetArea(QWidget *widget) const
Qt::DockWidgetArea QMainWindowLayout::dockWidgetArea(const QWidget *widget) const
{
const QList<int> pathToWidget = layoutState.dockAreaLayout.indexOf(widget);
if (pathToWidget.isEmpty())

2
src/widgets/widgets/qmainwindowlayout_p.h
View File

@ -537,7 +537,7 @@ public:
void splitDockWidget(QDockWidget *after,
QDockWidget *dockwidget,
Qt::Orientation orientation);
Qt::DockWidgetArea dockWidgetArea(QWidget* widget) const;
Qt::DockWidgetArea dockWidgetArea(const QWidget* widget) const;
bool restoreDockWidget(QDockWidget *dockwidget);
#if QT_CONFIG(tabbar)
void tabifyDockWidget(QDockWidget *first, QDockWidget *second);