From f897f722e308d36dfc68ea1a3959f8c2d449dae0 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 21 Jun 2023 11:45:50 +0200 Subject: [PATCH] QFutureSynchronizer: mark ctors [[nodiscard]] QFutureSynchronizer is a RAII class. QUIP-0019 says that RAII class ctors should be marked as [[nodiscard]]. Task-number: QTBUG-104164 Change-Id: I0b6710f2b9a14d67f64150f240f819b8336e0929 Reviewed-by: Ivan Solovev (cherry picked from commit f403ef428efab5af857e85d9d28c5f7b64603ec0) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/thread/qfuturesynchronizer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/corelib/thread/qfuturesynchronizer.h b/src/corelib/thread/qfuturesynchronizer.h index 183e3ab3424..368ef0c81b2 100644 --- a/src/corelib/thread/qfuturesynchronizer.h +++ b/src/corelib/thread/qfuturesynchronizer.h @@ -17,7 +17,8 @@ class QFutureSynchronizer Q_DISABLE_COPY(QFutureSynchronizer) public: - QFutureSynchronizer() : m_cancelOnWait(false) { } + Q_NODISCARD_CTOR QFutureSynchronizer() : m_cancelOnWait(false) { } + Q_NODISCARD_CTOR explicit QFutureSynchronizer(QFuture future) : m_cancelOnWait(false) { addFuture(std::move(future)); }