From f77c7e1bf54288bd6720e8a41b7ac9a0486c93d5 Mon Sep 17 00:00:00 2001 From: Rym Bouabid Date: Thu, 14 Sep 2023 17:28:27 +0200 Subject: [PATCH] Revamp Local Fortune Server Example: Fix includes Fix include order to respect the Coding Conventions. Add needed includes to avoid Transitive includes. Remove uneeded classes. Remove QT_{BEGIN,END}_NAMESPACE because these are private Qt macros that should not be used in the examples. Task-number: QTBUG-117064 Pick-to: 6.6 6.5 Change-Id: Ie98d4fbddb18d5578e2651bdb4850527ff984582 Reviewed-by: Ivan Solovev --- examples/corelib/ipc/localfortuneserver/main.cpp | 4 ++-- examples/corelib/ipc/localfortuneserver/server.cpp | 9 +++++++-- examples/corelib/ipc/localfortuneserver/server.h | 7 +------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/examples/corelib/ipc/localfortuneserver/main.cpp b/examples/corelib/ipc/localfortuneserver/main.cpp index 291a6b3f22b..c18fa17dfbe 100644 --- a/examples/corelib/ipc/localfortuneserver/main.cpp +++ b/examples/corelib/ipc/localfortuneserver/main.cpp @@ -1,10 +1,10 @@ // Copyright (C) 2016 The Qt Company Ltd. // SPDX-License-Identifier: LicenseRef-Qt-Commercial OR BSD-3-Clause -#include - #include "server.h" +#include + int main(int argc, char *argv[]) { QApplication app(argc, argv); diff --git a/examples/corelib/ipc/localfortuneserver/server.cpp b/examples/corelib/ipc/localfortuneserver/server.cpp index bfdf425f5df..68ce037a485 100644 --- a/examples/corelib/ipc/localfortuneserver/server.cpp +++ b/examples/corelib/ipc/localfortuneserver/server.cpp @@ -3,8 +3,13 @@ #include "server.h" -#include -#include +#include +#include +#include +#include +#include +#include +#include Server::Server(QWidget *parent) : QDialog(parent) diff --git a/examples/corelib/ipc/localfortuneserver/server.h b/examples/corelib/ipc/localfortuneserver/server.h index 26e47923479..d574b7d6135 100644 --- a/examples/corelib/ipc/localfortuneserver/server.h +++ b/examples/corelib/ipc/localfortuneserver/server.h @@ -5,12 +5,7 @@ #define SERVER_H #include - -QT_BEGIN_NAMESPACE -class QLabel; -class QPushButton; -class QLocalServer; -QT_END_NAMESPACE +#include class Server : public QDialog {