1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_qmlstream: re-use QBuffer instance in readBack()

Browse Source 
This improves the runtime of this particular test function by
almost 17% on my machine.

Change-Id: Icd77cdda92374b92121988c99e56787d405fa2d9
Reviewed-by: Mate Barany <mate.barany@qt.io>
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
(cherry picked from commit 7fa6670fa4ff5a916477f14d5754f9337ec9f1a8)
This commit is contained in:
Marc Mutz 2022-12-12 15:17:54 +01:00
parent 92d13e933d
commit f7381cecf4
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/auto/corelib/serialization/qxmlstream/tst_qxmlstream.cpp
View File

@ -1659,10 +1659,11 @@ static bool isValidSingleTextChar(const ushort c)
void tst_QXmlStream::readBack() const
{
for (ushort c = 0; c < std::numeric_limits<ushort>::max(); ++c) {
QBuffer buffer;
QBuffer buffer;
QVERIFY(buffer.open(QIODevice::WriteOnly));
for (ushort c = 0; c < std::numeric_limits<ushort>::max(); ++c) {
QVERIFY(buffer.open(QIODevice::WriteOnly|QIODevice::Truncate));
QXmlStreamWriter writer(&buffer);
writer.writeStartDocument();
writer.writeTextElement("a", QString(QChar(c)));