1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

CMake: Remove superfluous code from qt_evaluate_config_expression

Browse Source 
All of the continue() statements are not needed. There is no code after
the if-else chain.

Change-Id: I16188d14b4f05cb1e5f29bac4657149c4fce60a4
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Amir Masoud Abdol <amir.abdol@qt.io>
This commit is contained in:
Joerg Bornemann 2023-09-21 09:11:16 +02:00
parent 5bfac5358a
commit f5fc45bcb4
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cmake/QtFeature.cmake
View File

@ -102,7 +102,6 @@ function(qt_evaluate_config_expression resultVar)
list(APPEND result ${member}) list(APPEND result ${member})
endif() endif()
math(EXPR nestingLevel "${nestingLevel} + 1") math(EXPR nestingLevel "${nestingLevel} + 1")
continue()
elseif("${member}" STREQUAL ")") elseif("${member}" STREQUAL ")")
math(EXPR nestingLevel "${nestingLevel} - 1") math(EXPR nestingLevel "${nestingLevel} - 1")
if(nestingLevel LESS 0) if(nestingLevel LESS 0)
@ -113,13 +112,10 @@ function(qt_evaluate_config_expression resultVar)
else() else()
list(APPEND result ${member}) list(APPEND result ${member})
endif() endif()
continue()
elseif(${nestingLevel} GREATER 0) elseif(${nestingLevel} GREATER 0)
list(APPEND result ${member}) list(APPEND result ${member})
continue()
elseif("${member}" STREQUAL "NOT") elseif("${member}" STREQUAL "NOT")
list(APPEND result ${member}) list(APPEND result ${member})
continue()
elseif("${member}" STREQUAL "AND") elseif("${member}" STREQUAL "AND")
qt_evaluate_to_boolean(result) qt_evaluate_to_boolean(result)
if(NOT ${result}) if(NOT ${result})