1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

http2: perform clang-tidy suggestion to use emplace_back

Browse Source 
Change-Id: I4148f94a7d9944eddccaba6dbc956abcd2ad9937
Reviewed-by: Konrad Kujawa <konrad.kujawa@qt.io>
Reviewed-by: Ahmad Samir <a.samirh78@gmail.com>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Mårten Nordheim 2023-06-23 16:00:54 +02:00
parent 35450cde05
commit f49e62e782
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/network/access/qhttp2protocolhandler.cpp
View File

@ -45,10 +45,10 @@ HPack::HttpHeader build_headers(const QHttpNetworkRequest &request, quint32 maxH
// 1. Before anything - mandatory fields, if they do not fit into maxHeaderList - // 1. Before anything - mandatory fields, if they do not fit into maxHeaderList -
// then stop immediately with error. // then stop immediately with error.
const auto auth = request.url().authority(QUrl::FullyEncoded | QUrl::RemoveUserInfo).toLatin1(); const auto auth = request.url().authority(QUrl::FullyEncoded | QUrl::RemoveUserInfo).toLatin1();
header.push_back(HeaderField(":authority", auth)); header.emplace_back(":authority", auth);
header.push_back(HeaderField(":method", request.methodName())); header.emplace_back(":method", request.methodName());
header.push_back(HeaderField(":path", request.uri(useProxy))); header.emplace_back(":path", request.uri(useProxy));
header.push_back(HeaderField(":scheme", request.url().scheme().toLatin1())); header.emplace_back(":scheme", request.url().scheme().toLatin1());
HeaderSize size = header_size(header); HeaderSize size = header_size(header);
if (!size.first) // Ooops! if (!size.first) // Ooops!
@ -79,7 +79,7 @@ HPack::HttpHeader build_headers(const QHttpNetworkRequest &request, quint32 maxH
// to their encoding in HTTP/2. // to their encoding in HTTP/2.
// A request or response containing uppercase header field names // A request or response containing uppercase header field names
// MUST be treated as malformed (Section 8.1.2.6)". // MUST be treated as malformed (Section 8.1.2.6)".
header.push_back(HeaderField(field.first.toLower(), field.second)); header.emplace_back(field.first.toLower(), field.second);
} }
return header; return header;