1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass a parent pointer to the Animation instance to avoid memory leak

Browse Source 
The leak is just on termination, but we should show good practices in
our examples

Change-Id: I39abb7545d3c68a1a537b865ba3fcb5e60c22fbf
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
(cherry picked from commit 30947c7fd4dddd76b69a3aa11567e27174d7a3ea)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Jan Arve Sæther 2022-09-08 12:56:24 +02:00 committed by Qt Cherry-pick Bot
parent b46e179186
commit f442fcaa6c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
examples/widgets/animation/easing/animation.h
View File

@ -62,8 +62,8 @@ public:
CirclePath, CirclePath,
NPathTypes NPathTypes
}; };
Animation(QObject *target, const QByteArray &prop) Animation(QObject *target, const QByteArray &prop, QObject *parent = nullptr)
: QPropertyAnimation(target, prop) : QPropertyAnimation(target, prop, parent)
{ {
setPathType(LinearPath); setPathType(LinearPath);
} }

2
examples/widgets/animation/easing/window.cpp
View File

@ -82,7 +82,7 @@ Window::Window(QWidget *parent)
m_scene.addItem(m_item); m_scene.addItem(m_item);
m_ui.graphicsView->setScene(&m_scene); m_ui.graphicsView->setScene(&m_scene);
m_anim = new Animation(m_item, "pos"); m_anim = new Animation(m_item, "pos", this);
m_anim->setEasingCurve(QEasingCurve::OutBounce); m_anim->setEasingCurve(QEasingCurve::OutBounce);
m_ui.easingCurvePicker->setCurrentRow(int(QEasingCurve::OutBounce)); m_ui.easingCurvePicker->setCurrentRow(int(QEasingCurve::OutBounce));