1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QSpan: remove a stale static constexpr extent from a base class

Browse Source 
It's not needed, and might trigger -Wshadow on some compilers. Only
the public QSpan class has the `extent` static data member, everything
else uses the template argument, `E`, directly.

Amends f82cf6333e4e21c96d8b6bb272392f8142ead2b7.

Change-Id: If378119aff1e352d1e90854b570720444cd532a0
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Dennis Oberst <dennis.oberst@qt.io>
(cherry picked from commit 9a0ae6c13bb8ad6c883285fea6fe494b532fc5e5)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Marc Mutz 2023-10-10 18:23:06 +02:00 committed by Qt Cherry-pick Bot
parent e13917ec14
commit f3280a8384
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/corelib/tools/qspan_p.h
View File

@ -151,8 +151,7 @@ protected:
static constexpr qsizetype m_size = qsizetype(E);
// types and constants:
static constexpr size_t extent = E;
// (in QSpan only)
// constructors (need to be public d/t the way ctor inheriting works):
public: