1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

tst_QVersionNumber: fix Clang warning about superfluous move

Browse Source 
Parameters passed by value, like local function variables, are subject
to NRVO/return-by-move already, so adding std::move, even disguised as
qMove(), makes Clang warn about a pessimizing move.

Change-Id: I7d59bfee4cf7ecddee0874ee489367044c702643
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
This commit is contained in:
Marc Mutz 2017-03-06 11:29:26 +01:00
parent 37fd42459e
commit f31dbeb4c7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/auto/corelib/tools/qversionnumber/tst_qversionnumber.cpp
View File

@ -134,7 +134,7 @@ void tst_QVersionNumber::singleInstanceData()
namespace UglyOperator {
// ugh, but the alternative (operator <<) is even worse...
static inline QVector<int> operator+(QVector<int> v, int i) { v.push_back(i); return qMove(v); }
static inline QVector<int> operator+(QVector<int> v, int i) { v.push_back(i); return v; }
}
void tst_QVersionNumber::comparisonData()