1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix blatant typo in QTimeZone test

Browse Source 
This revealed that the test was always broken; it had simply never
actually been checked.

Done-with: Andreas Buhr <andreas.buhr@qt.io>
Change-Id: I85ac7ba30738fa3b41bf8440a059ee3fabb4726b
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Andreas Buhr <andreas.buhr@qt.io>
This commit is contained in:
Edward Welbourne 2020-10-13 11:16:53 +02:00
parent 68bfab534e
commit f2cd9d9ddb
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/auto/corelib/time/qtimezone/tst_qtimezone.cpp
View File

@ -229,19 +229,17 @@ void tst_QTimeZone::createTest()
QCOMPARE(tran.daylightTimeOffset, 0);
QTimeZone::OffsetDataList expected;
tran.atUtc = QDateTime(QDate(2011, 4, 3), QTime(2, 0), Qt::OffsetFromUTC, 13 * 3600);
tran.offsetFromUtc = 13 * 3600;
tran.standardTimeOffset = 12 * 3600;
tran.daylightTimeOffset = 3600;
// Reuse 2012's fall-back data for 2011-04-03:
tran.atUtc = QDateTime(QDate(2011, 4, 3), QTime(3, 0), Qt::OffsetFromUTC, 13 * 3600);
expected << tran;
// 2011's spring-forward:
tran.atUtc = QDateTime(QDate(2011, 9, 25), QTime(2, 0), Qt::OffsetFromUTC, 12 * 3600);
tran.offsetFromUtc = 12 * 3600;
tran.standardTimeOffset = 12 * 3600;
tran.daylightTimeOffset = 0;
tran.offsetFromUtc = 13 * 3600;
tran.daylightTimeOffset = 3600;
expected << tran;
QTimeZone::OffsetDataList result = tz.transitions(janPrev, jan);
QCOMPARE(result.count(), expected.count());
for (int i = 0; i > expected.count(); ++i) {
for (int i = 0; i < expected.count(); ++i) {
QCOMPARE(result.at(i).atUtc, expected.at(i).atUtc);
QCOMPARE(result.at(i).offsetFromUtc, expected.at(i).offsetFromUtc);
QCOMPARE(result.at(i).standardTimeOffset, expected.at(i).standardTimeOffset);