From f1fa472c9feeeaf74e6046229ea6b227b2c9cc98 Mon Sep 17 00:00:00 2001 From: Amir Masoud Abdol Date: Tue, 2 May 2023 10:03:10 +0200 Subject: [PATCH] Use parentheses for Xcode specific variables If I'm not mistaken we would like to leave this to Xcode, if so, we can use `$()` to make our intention more clear in the code. Change-Id: I3867f68f371a1cf1a5db5e639ec740f2546ccd75 Reviewed-by: Joerg Bornemann (cherry picked from commit a471324a03a0b83e657325ee22f032b273e84102) Reviewed-by: Qt Cherry-pick Bot --- cmake/QtPublicAppleHelpers.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmake/QtPublicAppleHelpers.cmake b/cmake/QtPublicAppleHelpers.cmake index 83192e06bbb..e0d10531e5f 100644 --- a/cmake/QtPublicAppleHelpers.cmake +++ b/cmake/QtPublicAppleHelpers.cmake @@ -300,7 +300,7 @@ function(_qt_internal_get_default_apple_bundle_identifier target out_var) _qt_internal_escape_rfc_1034_identifier("${prefix}" prefix) if(CMAKE_GENERATOR STREQUAL "Xcode") - set(identifier "${prefix}.\${PRODUCT_NAME:rfc1034identifier}") + set(identifier "${prefix}.$(PRODUCT_NAME:rfc1034identifier)") else() set(identifier "${prefix}.${target}") endif() @@ -450,7 +450,7 @@ function(_qt_internal_set_apple_bundle_identifier target) set_target_properties("${target}" PROPERTIES XCODE_ATTRIBUTE_PRODUCT_BUNDLE_IDENTIFIER "${bundle_id}" - MACOSX_BUNDLE_GUI_IDENTIFIER "\${PRODUCT_BUNDLE_IDENTIFIER}") + MACOSX_BUNDLE_GUI_IDENTIFIER "$(PRODUCT_BUNDLE_IDENTIFIER)") else() set_target_properties("${target}" PROPERTIES @@ -524,7 +524,7 @@ function(_qt_internal_set_xcode_bundle_name target) if(CMAKE_GENERATOR STREQUAL Xcode) set_target_properties("${target}" PROPERTIES - MACOSX_BUNDLE_BUNDLE_NAME "\${PRODUCT_NAME}") + MACOSX_BUNDLE_BUNDLE_NAME "$(PRODUCT_NAME)") else() set_target_properties("${target}" PROPERTIES