1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

windeployqt: Make "recursive plugin deployment" the default

Browse Source 
5010eda5345bdbfc12e134d6fb3ae5b7370e2185 added a command line options
which made sure that plugins of dependent Qt modules were deployed. As
these plugins are mandatory for proper functionality of these modules,
this should be windeployqt's default. This change reflects this reality.
Deploy plugins of dependent Qt libraries by default.

The command line option was removed as opting out of this functionality
does not make sense

[ChangeLog][Tools][windeployqt] windeployqt now deploys plugins of all
dependent Qt modules by default. "--include-soft-plugins" became default
and the command line option was removed.

Change-Id: Ifc5e4d24803b0398c249461f14f2e58562477c80
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
This commit is contained in:
Oliver Wolff 2025-03-26 09:15:08 +01:00 committed by Joerg Bornemann
parent 2ab472f6cb
commit f017087214
2 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/tools/windeployqt/main.cpp
View File

@ -406,10 +406,6 @@ static inline int parseArguments(const QStringList &arguments, QCommandLineParse
QStringLiteral("Skip plugin deployment."));
parser->addOption(noPluginsOption);
QCommandLineOption includeSoftPluginsOption(QStringLiteral("include-soft-plugins"),
QStringLiteral("Include in the deployment all relevant plugins by taking into account all soft dependencies."));
parser->addOption(includeSoftPluginsOption);
QCommandLineOption skipPluginTypesOption(QStringLiteral("skip-plugin-types"),
QStringLiteral("A comma-separated list of plugin types that are not deployed (qmltooling,generic)."),
QStringLiteral("plugin types"));
@ -580,8 +576,6 @@ static inline int parseArguments(const QStringList &arguments, QCommandLineParse
return CommandLineParseError;
}
options->pluginSelections.includeSoftPlugins = parser->isSet(includeSoftPluginsOption);
if (parser->isSet(skipPluginTypesOption))
options->pluginSelections.disabledPluginTypes = parser->value(skipPluginTypesOption).split(u',');
@ -1127,7 +1121,7 @@ QStringList findQtPlugins(ModuleBitset *usedQtModules, const ModuleBitset &disab
// If missing Qt modules were added during plugin deployment make additional pass, because we may need
// additional plugins.
if (pluginSelections.includeSoftPlugins && missingQtModulesAdded) {
if (missingQtModulesAdded) {
if (optVerboseLevel) {
std::wcout << "Performing additional pass of finding Qt plugins due to updated Qt module list: "
<< formatQtModules(*usedQtModules).constData() << "\n";

1
src/tools/windeployqt/qtplugininfo.h
View File

@ -24,7 +24,6 @@ struct PluginSelections
QStringList enabledPluginTypes;
QStringList excludedPlugins;
QStringList includedPlugins;
bool includeSoftPlugins = false;
};
class PluginInformation