From eef0013086bc23e4951c1a09018f9fc23f185f72 Mon Sep 17 00:00:00 2001 From: Marc Mutz Date: Wed, 17 Aug 2022 22:27:39 +0200 Subject: [PATCH] QDirPrivate: pass input QList by cref MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Unlike the mutable lvalue reference that was previously used to pass it suggested, the input is never modified, so pass by const reference. Pick-to: 6.4 6.3 6.2 5.15 Change-Id: I5659fe5eab4a8953cd36134735e9e8fd9601f530 Reviewed-by: Sona Kurazyan Reviewed-by: Mårten Nordheim --- src/corelib/io/qdir.cpp | 2 +- src/corelib/io/qdir_p.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/corelib/io/qdir.cpp b/src/corelib/io/qdir.cpp index 26f30fba6a9..5a6f78df63d 100644 --- a/src/corelib/io/qdir.cpp +++ b/src/corelib/io/qdir.cpp @@ -276,7 +276,7 @@ bool QDirSortItemComparator::operator()(const QDirSortItem &n1, const QDirSortIt return r < 0; } -inline void QDirPrivate::sortFileList(QDir::SortFlags sort, QFileInfoList &l, +inline void QDirPrivate::sortFileList(QDir::SortFlags sort, const QFileInfoList &l, QStringList *names, QFileInfoList *infos) { // names and infos are always empty lists or 0 here diff --git a/src/corelib/io/qdir_p.h b/src/corelib/io/qdir_p.h index 7f90f8d1674..9f6be858e54 100644 --- a/src/corelib/io/qdir_p.h +++ b/src/corelib/io/qdir_p.h @@ -44,7 +44,7 @@ public: void initFileEngine(); void initFileLists(const QDir &dir) const; - static void sortFileList(QDir::SortFlags, QFileInfoList &, QStringList *, QFileInfoList *); + static void sortFileList(QDir::SortFlags, const QFileInfoList &, QStringList *, QFileInfoList *); static inline QChar getFilterSepChar(const QString &nameFilter);