1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Baseline: add stylesheet setting show-decoration-selected for treeview

Browse Source 
The fix for QTBUG-73251 in f4976f86cd265d7505da449dafe15c51e3c8cdc0
resulted in QTBUG-106227. Add baseline test coverage for the respective
configuration to make sure we don't regress.

Refactor mapping of index to configuration to make accessing of subitems
more robust.

Task-number: QTBUG-73251
Change-Id: I530ecd67fa5663f219884f641bc5e25c7ac5fe73
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit 6f9d31be493dfe72bd8332881b325f811c79523d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
This commit is contained in:
Volker Hilsheimer 2022-10-23 11:57:17 +02:00 committed by Qt Cherry-pick Bot
parent 51881862eb
commit eed3f07e02
2 changed files with 24 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tests/baseline/stylesheet/qss/qtreeview/showDecorationSelected.qss Normal file
View File

@ -0,0 +1,3 @@
QTreeView {
show-decoration-selected: 1
}

29
tests/baseline/stylesheet/tst_baseline_stylesheet.cpp
View File

@ -160,19 +160,29 @@ void tst_Stylesheet::tst_QTreeView()
tw->header()->hide(); tw->header()->hide();
layout->addWidget(tw); layout->addWidget(tw);
for (int i = 0; i < 6; ++i) { enum {
Unchecked = 0,
Checked = 1,
Children = 2,
Disabled = 3,
CheckedDisabled = 4,
ChildrenDisabled = 5,
NConfigs
};
for (int i = 0; i < NConfigs; ++i) {
QTreeWidgetItem *topLevelItem = new QTreeWidgetItem(tw, QStringList{QString("top %1").arg(i)}); QTreeWidgetItem *topLevelItem = new QTreeWidgetItem(tw, QStringList{QString("top %1").arg(i)});
switch (i) { switch (i) {
case 0: case Unchecked:
case 3: case Disabled:
topLevelItem->setCheckState(0, Qt::Unchecked); topLevelItem->setCheckState(0, Qt::Unchecked);
break; break;
case 1: case Checked:
case 4: case CheckedDisabled:
topLevelItem->setCheckState(0, Qt::Checked); topLevelItem->setCheckState(0, Qt::Checked);
break; break;
case 2: case Children:
case 5: case ChildrenDisabled:
topLevelItem->setCheckState(0, Qt::PartiallyChecked); topLevelItem->setCheckState(0, Qt::PartiallyChecked);
topLevelItem->setExpanded(true); topLevelItem->setExpanded(true);
for (int j = 0; j < 2; ++j) { for (int j = 0; j < 2; ++j) {
@ -181,7 +191,7 @@ void tst_Stylesheet::tst_QTreeView()
} }
break; break;
} }
topLevelItem->setDisabled(i > 2); topLevelItem->setDisabled(i >= Disabled);
} }
testWindow()->setLayout(layout); testWindow()->setLayout(layout);
tw->setRootIsDecorated(true); tw->setRootIsDecorated(true);
@ -190,6 +200,9 @@ void tst_Stylesheet::tst_QTreeView()
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootDecorated"); QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootDecorated");
tw->setRootIsDecorated(false); tw->setRootIsDecorated(false);
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootNotDecorated"); QBASELINE_CHECK_DEFERRED(takeSnapshot(), "rootNotDecorated");
tw->topLevelItem(Children)->child(0)->setSelected(true);
QBASELINE_CHECK_DEFERRED(takeSnapshot(), "itemSelected");
} }
#define main _realmain #define main _realmain