From eed30ff3520bd4371e91c1381b4f8ed8b0c78ab2 Mon Sep 17 00:00:00 2001 From: Volker Hilsheimer Date: Thu, 18 Apr 2024 12:02:27 +0200 Subject: [PATCH] Replace expensive inherits with cheaper qobject_cast (1) The accessibility implementations require the type to be fully defined anyway in order to call type-specific APIs, so there's no need to use inherits(). Use qobject_cast instead. Change-Id: I5c013be57f48272a748451f4888911fe6aa6574e Reviewed-by: Pavel Dubsky Reviewed-by: Santhosh Kumar (cherry picked from commit 3973d6c529605fbce8457d7663d244ebadbe7160) Reviewed-by: Qt Cherry-pick Bot --- src/widgets/accessible/qaccessiblewidgets.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/widgets/accessible/qaccessiblewidgets.cpp b/src/widgets/accessible/qaccessiblewidgets.cpp index 1c29de8caf4..5c2a3bd02b8 100644 --- a/src/widgets/accessible/qaccessiblewidgets.cpp +++ b/src/widgets/accessible/qaccessiblewidgets.cpp @@ -95,7 +95,7 @@ QWidgetList _q_ac_childWidgets(const QWidget *widget) QAccessiblePlainTextEdit::QAccessiblePlainTextEdit(QWidget* o) :QAccessibleTextWidget(o) { - Q_ASSERT(widget()->inherits("QPlainTextEdit")); + Q_ASSERT(qobject_cast(widget())); } QPlainTextEdit* QAccessiblePlainTextEdit::plainTextEdit() const @@ -192,7 +192,7 @@ void QAccessiblePlainTextEdit::scrollToSubstring(int startIndex, int endIndex) QAccessibleTextEdit::QAccessibleTextEdit(QWidget *o) : QAccessibleTextWidget(o, QAccessible::EditableText) { - Q_ASSERT(widget()->inherits("QTextEdit")); + Q_ASSERT(qobject_cast(widget())); } /*! Returns the text edit. */