From ee95cb90c44225c8c9d3821b896e8f3cfeb9c79b Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Fri, 6 Jun 2025 22:28:50 -0300 Subject: [PATCH] QVarLengthArray: use assign() for the iterator,iterator ctor MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Let's avoid std::back_inserter for non-complex types, which generates a huge amount of unnecessary code. The implementation of assign() is far more modern. Change-Id: Ia8b9c90336af2bebd49ffffd0d69ace761c6aa59 Reviewed-by: MÃ¥rten Nordheim Reviewed-by: Marc Mutz (cherry picked from commit 96dfe0373c80964ae9de7955a06f5c7696961f12) Reviewed-by: Qt Cherry-pick Bot --- src/corelib/tools/qvarlengtharray.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/corelib/tools/qvarlengtharray.h b/src/corelib/tools/qvarlengtharray.h index efc58beebf5..0db433cb623 100644 --- a/src/corelib/tools/qvarlengtharray.h +++ b/src/corelib/tools/qvarlengtharray.h @@ -360,8 +360,7 @@ public: inline QVarLengthArray(InputIterator first, InputIterator last) : QVarLengthArray() { - QtPrivate::reserveIfForwardIterator(this, first, last); - std::copy(first, last, std::back_inserter(*this)); + assign(first, last); } inline ~QVarLengthArray()