From edd3c0e6a7626cc2e9a259ccd085cfb56da7f3b9 Mon Sep 17 00:00:00 2001 From: Thiago Macieira Date: Thu, 21 Jul 2022 11:24:17 -0700 Subject: [PATCH] tst_QMetaType: fix warning that buffer may be unused MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We pass a pointer to uninitialized memory to QMetaType::create(). There's no harm because we're using the invalid QMetaType, but GCC is actually right to complain for any other type. qtestcase.h:54:25: warning: ‘buf’ may be used uninitialized [-Wmaybe-uninitialized] qmetatype.h:454:11: note: by argument 2 of type ‘const void*’ to ‘void* QMetaType::create(const void*) const’ declared here Change-Id: I3859764fed084846bcb0fffd1703eb7967acf0d7 Reviewed-by: Mårten Nordheim (cherry picked from commit f1457b7b4742a3903b441d04c12cf500038f80b8) Reviewed-by: Qt Cherry-pick Bot --- tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp index 422a3221ca8..652065a6e52 100644 --- a/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp +++ b/tests/auto/corelib/kernel/qmetatype/tst_qmetatype.cpp @@ -815,7 +815,7 @@ void tst_QMetaType::createCopy() switch (type) { case QMetaType::UnknownType: return []() { - char buf[1]; + char buf[1] = {}; QCOMPARE(QMetaType().create(&buf), nullptr); }; #define RETURN_CREATE_COPY_FUNCTION(MetaTypeName, MetaTypeId, RealType) \ @@ -1328,7 +1328,7 @@ void tst_QMetaType::constructCopy() switch (type) { case QMetaType::UnknownType: return []() { - char buf[1], buf2[1]; + char buf[1], buf2[1] = {}; QCOMPARE(QMetaType().construct(&buf, &buf2), nullptr); }; #define RETURN_CONSTRUCT_COPY_FUNCTION(MetaTypeName, MetaTypeId, RealType) \