1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop pointless parentheses from round case labels

Browse Source 
Change-Id: I5339523f83aea4d91aaec9bd2570b225287ae23a
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
This commit is contained in:
Edward Welbourne 2021-07-05 18:19:52 +02:00
parent 31e094922c
commit ec7b836455
1 changed files with 20 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
tests/benchmarks/corelib/io/qfile/main.cpp
View File

@ -249,7 +249,7 @@ void tst_qfile::readBigFile()
char buffer[BUFSIZE]; char buffer[BUFSIZE];
switch (testType) { switch (testType) {
case(QFileBenchmark): { case QFileBenchmark: {
QFile file(tempDir.filename); QFile file(tempDir.filename);
file.open(QIODevice::ReadOnly|textMode|bufferedMode); file.open(QIODevice::ReadOnly|textMode|bufferedMode);
QBENCHMARK { QBENCHMARK {
@ -261,7 +261,7 @@ void tst_qfile::readBigFile()
} }
break; break;
#ifdef QT_BUILD_INTERNAL #ifdef QT_BUILD_INTERNAL
case(QFSFileEngineBenchmark): { case QFSFileEngineBenchmark: {
QFSFileEngine fse(tempDir.filename); QFSFileEngine fse(tempDir.filename);
fse.open(QIODevice::ReadOnly|textMode|bufferedMode); fse.open(QIODevice::ReadOnly|textMode|bufferedMode);
QBENCHMARK { QBENCHMARK {
@ -273,7 +273,7 @@ void tst_qfile::readBigFile()
} }
break; break;
#endif #endif
case(PosixBenchmark): { case PosixBenchmark: {
QByteArray data = tempDir.filename.toLocal8Bit(); QByteArray data = tempDir.filename.toLocal8Bit();
const char* cfilename = data.constData(); const char* cfilename = data.constData();
FILE* cfile = ::fopen(cfilename, "rb"); FILE* cfile = ::fopen(cfilename, "rb");
@ -285,11 +285,11 @@ void tst_qfile::readBigFile()
::fclose(cfile); ::fclose(cfile);
} }
break; break;
case(QFileFromPosixBenchmark): { case QFileFromPosixBenchmark: {
// No gain in benchmarking this case // No gain in benchmarking this case
} }
break; break;
case(Win32Benchmark): { case Win32Benchmark: {
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
HANDLE hndl; HANDLE hndl;
@ -336,7 +336,7 @@ void tst_qfile::seek()
int i = 0; int i = 0;
switch (testType) { switch (testType) {
case(QFileBenchmark): { case QFileBenchmark: {
QFile file(tempDir.filename); QFile file(tempDir.filename);
file.open(QIODevice::ReadOnly); file.open(QIODevice::ReadOnly);
QBENCHMARK { QBENCHMARK {
@ -347,7 +347,7 @@ void tst_qfile::seek()
} }
break; break;
#ifdef QT_BUILD_INTERNAL #ifdef QT_BUILD_INTERNAL
case(QFSFileEngineBenchmark): { case QFSFileEngineBenchmark: {
QFSFileEngine fse(tempDir.filename); QFSFileEngine fse(tempDir.filename);
fse.open(QIODevice::ReadOnly | QIODevice::Unbuffered); fse.open(QIODevice::ReadOnly | QIODevice::Unbuffered);
QBENCHMARK { QBENCHMARK {
@ -358,7 +358,7 @@ void tst_qfile::seek()
} }
break; break;
#endif #endif
case(PosixBenchmark): { case PosixBenchmark: {
QByteArray data = tempDir.filename.toLocal8Bit(); QByteArray data = tempDir.filename.toLocal8Bit();
const char* cfilename = data.constData(); const char* cfilename = data.constData();
FILE* cfile = ::fopen(cfilename, "rb"); FILE* cfile = ::fopen(cfilename, "rb");
@ -369,11 +369,11 @@ void tst_qfile::seek()
::fclose(cfile); ::fclose(cfile);
} }
break; break;
case(QFileFromPosixBenchmark): { case QFileFromPosixBenchmark: {
// No gain in benchmarking this case // No gain in benchmarking this case
} }
break; break;
case(Win32Benchmark): { case Win32Benchmark: {
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
HANDLE hndl; HANDLE hndl;
@ -414,7 +414,7 @@ void tst_qfile::open()
QFETCH(tst_qfile::BenchmarkType, testType); QFETCH(tst_qfile::BenchmarkType, testType);
switch (testType) { switch (testType) {
case(QFileBenchmark): { case QFileBenchmark: {
QBENCHMARK { QBENCHMARK {
QFile file(tempDir.filename); QFile file(tempDir.filename);
file.open(QIODevice::ReadOnly); file.open(QIODevice::ReadOnly);
@ -423,7 +423,7 @@ void tst_qfile::open()
} }
break; break;
#ifdef QT_BUILD_INTERNAL #ifdef QT_BUILD_INTERNAL
case(QFSFileEngineBenchmark): { case QFSFileEngineBenchmark: {
QBENCHMARK { QBENCHMARK {
QFSFileEngine fse(tempDir.filename); QFSFileEngine fse(tempDir.filename);
fse.open(QIODevice::ReadOnly | QIODevice::Unbuffered); fse.open(QIODevice::ReadOnly | QIODevice::Unbuffered);
@ -432,7 +432,7 @@ void tst_qfile::open()
} }
break; break;
#endif #endif
case(PosixBenchmark): { case PosixBenchmark: {
// ensure we don't account toLocal8Bit() // ensure we don't account toLocal8Bit()
QByteArray data = tempDir.filename.toLocal8Bit(); QByteArray data = tempDir.filename.toLocal8Bit();
const char* cfilename = data.constData(); const char* cfilename = data.constData();
@ -443,7 +443,7 @@ void tst_qfile::open()
} }
} }
break; break;
case(QFileFromPosixBenchmark): { case QFileFromPosixBenchmark: {
// ensure we don't account toLocal8Bit() // ensure we don't account toLocal8Bit()
QByteArray data = tempDir.filename.toLocal8Bit(); QByteArray data = tempDir.filename.toLocal8Bit();
const char* cfilename = data.constData(); const char* cfilename = data.constData();
@ -457,7 +457,7 @@ void tst_qfile::open()
::fclose(cfile); ::fclose(cfile);
} }
break; break;
case(Win32Benchmark): { case Win32Benchmark: {
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
HANDLE hndl; HANDLE hndl;
@ -524,7 +524,7 @@ void tst_qfile::readSmallFiles()
char buffer[BUFSIZE]; char buffer[BUFSIZE];
switch (testType) { switch (testType) {
case(QFileBenchmark): { case QFileBenchmark: {
QList<QFile*> fileList; QList<QFile*> fileList;
for (const QString &file : files) { for (const QString &file : files) {
QFile *f = new QFile(tempDir.filePath(file)); QFile *f = new QFile(tempDir.filePath(file));
@ -546,7 +546,7 @@ void tst_qfile::readSmallFiles()
} }
break; break;
#ifdef QT_BUILD_INTERNAL #ifdef QT_BUILD_INTERNAL
case(QFSFileEngineBenchmark): { case QFSFileEngineBenchmark: {
QList<QFSFileEngine*> fileList; QList<QFSFileEngine*> fileList;
for (const QString &file : files) { for (const QString &file : files) {
QFSFileEngine *fse = new QFSFileEngine(tempDir.filePath(file)); QFSFileEngine *fse = new QFSFileEngine(tempDir.filePath(file));
@ -566,7 +566,7 @@ void tst_qfile::readSmallFiles()
} }
break; break;
#endif #endif
case(PosixBenchmark): { case PosixBenchmark: {
QList<FILE *> fileList; QList<FILE *> fileList;
for (const QString &file : files) for (const QString &file : files)
fileList.append(::fopen(QFile::encodeName(tempDir.filePath(file)).constData(), "rb")); fileList.append(::fopen(QFile::encodeName(tempDir.filePath(file)).constData(), "rb"));
@ -583,11 +583,11 @@ void tst_qfile::readSmallFiles()
::fclose(cfile); ::fclose(cfile);
} }
break; break;
case(QFileFromPosixBenchmark): { case QFileFromPosixBenchmark: {
// No gain in benchmarking this case // No gain in benchmarking this case
} }
break; break;
case(Win32Benchmark): { case Win32Benchmark: {
#ifdef Q_OS_WIN #ifdef Q_OS_WIN
HANDLE hndl; HANDLE hndl;