1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix wrong note "Using pthreads" and only show it for WASM

Browse Source 
MSVC does not have pthreads.

"QT_FEATURE_thread" should mean "Enable thread support".

And I think this note is only meaningful for WASM. For other platforms,
thread support should be enabled by default.

amends 4972fdb350fe79e18b0413e74028cd9b9803f96b

Change-Id: I5a4fc05219c9b2ff9c6e54fd444b4b94230727bb
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
This commit is contained in:
Li Xinwei 2021-04-29 22:29:32 +08:00
parent 2ecd0f4194
commit ebf91d1d13
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
configure.cmake
View File

@ -1131,8 +1131,8 @@ qt_configure_add_report_entry(
)
qt_configure_add_report_entry(
TYPE NOTE
MESSAGE "Using pthreads"
CONDITION QT_FEATURE_thread
MESSAGE "Enable thread support"
CONDITION QT_FEATURE_thread AND WASM
)
qt_configure_add_report_entry(
TYPE WARNING

4
configure.json
View File

@ -1514,8 +1514,8 @@
},
{
"type": "note",
"condition": "features.thread",
"message": "Using pthreads"
"condition": "features.thread && config.wasm",
"message": "Enable thread support"
},
{
"type": "error",