1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QStringConverterBase: make it move-only

Browse Source 
The class declares a protected destructor, which interferes with the
RO5. The only subclass in qtbase is move-only; QTextCodec (in
Core5Compat) is not even movable.
Make QStringConverterBase move-only as well.

Pick-to: 6.9 6.8
Change-Id: I20d16df79f7ad8e7e7a8af339954cfa2d1482e96
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
This commit is contained in:
Giuseppe D'Angelo 2025-01-13 14:22:33 +01:00
parent 20a401cd9f
commit eb533c81b8
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/corelib/text/qstringconverter_base.h
View File

@ -81,7 +81,10 @@ public:
Q_DISABLE_COPY(State)
};
protected:
QStringConverterBase() = default;
~QStringConverterBase() = default;
QStringConverterBase(QStringConverterBase &&) = default;
QStringConverterBase &operator=(QStringConverterBase &&) = default;
};
Q_DECLARE_OPERATORS_FOR_FLAGS(QStringConverterBase::Flags)