From e9f1dd072d0601d077a943f07592714636e4a3b5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20Wierci=C5=84ski?= <piotr.wiercinski@qt.io>
Date: Mon, 16 Sep 2024 12:38:37 +0200
Subject: [PATCH] wasm: Fix integer overflow in FetchRequest
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove code which is trying to unset flag that has never been set
before. Subtracting flag on unsigned int "attributes" can cause integer
overlow.

Fixes: QTBUG-128929
Pick-to: 6.7 6.5
Change-Id: I4128819f29a841b73b6a08aeba795dcae9dc2e51
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
(cherry picked from commit 21be40019f8adedf1e592b9b8ba0d965b857eef3)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
---
 src/network/access/qnetworkreplywasmimpl.cpp | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/network/access/qnetworkreplywasmimpl.cpp b/src/network/access/qnetworkreplywasmimpl.cpp
index ed34b688834..e7e66183f58 100644
--- a/src/network/access/qnetworkreplywasmimpl.cpp
+++ b/src/network/access/qnetworkreplywasmimpl.cpp
@@ -264,11 +264,6 @@ void QNetworkReplyWasmImplPrivate::doSendRequest()
          attr.attributes += EMSCRIPTEN_FETCH_APPEND;
     }
 
-    if (CacheLoadControlAttribute == QNetworkRequest::AlwaysNetwork ||
-            request.attribute(QNetworkRequest::CacheSaveControlAttribute, false).toBool()) {
-        attr.attributes -= EMSCRIPTEN_FETCH_PERSIST_FILE;
-    }
-
     attr.withCredentials = request.attribute(QNetworkRequest::UseCredentialsAttribute, false).toBool();
     attr.onsuccess = QNetworkReplyWasmImplPrivate::downloadSucceeded;
     attr.onerror = QNetworkReplyWasmImplPrivate::downloadFailed;