1berry/qtbase
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

QLoggingRegistry: don't iterate over QHash::keys()

Browse Source 
... but use the new key_iterators instead.

Saves creating a temporary QList just to iterate over it
and ~1.3KiB in text size on optimized GCC 4.9 Linux AMD64
builds.

Change-Id: Id5223fc5fcb4a4e7c012718c1bb2674b8ea0439d
Reviewed-by: Sérgio Martins <iamsergio@gmail.com>
This commit is contained in:
Marc Mutz 2015-12-26 03:38:25 +01:00
parent 17504a7b32
commit e979f87217
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/corelib/io/qloggingregistry.cpp
View File

@ -364,8 +364,8 @@ void QLoggingRegistry::updateRules()
rules = qtConfigRules + configRules + apiRules + envRules; rules = qtConfigRules + configRules + apiRules + envRules;
foreach (QLoggingCategory *cat, categories.keys()) for (auto it = categories.keyBegin(), end = categories.keyEnd(); it != end; ++it)
(*categoryFilter)(cat); (*categoryFilter)(*it);
} }
/*! /*!
@ -383,8 +383,8 @@ QLoggingRegistry::installFilter(QLoggingCategory::CategoryFilter filter)
QLoggingCategory::CategoryFilter old = categoryFilter; QLoggingCategory::CategoryFilter old = categoryFilter;
categoryFilter = filter; categoryFilter = filter;
foreach (QLoggingCategory *cat, categories.keys()) for (auto it = categories.keyBegin(), end = categories.keyEnd(); it != end; ++it)
(*categoryFilter)(cat); (*categoryFilter)(*it);
return old; return old;
} }